Skip to content

fix error valid target in image-layout #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2017
Merged

fix error valid target in image-layout #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion image-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ The `imageLayoutVersion` value will align with the OCI Image Specification versi

### oci-layout Example

```json
```json,title=OCI%20Layout&mediatype=oci%2Dlayout
Copy link
Contributor

@wking wking Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still rather have “oci-layout file” (or similar) as the title and a real media type.

Copy link
Contributor Author

@xiekeyang xiekeyang Feb 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still rather have “oci-layout file” (or similar) as the title and a real media type.

it likely make no much sense. Refer to manifest.md or so.

Copy link
Contributor

@wking wking Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still rather have “oci-layout file” (or similar) as the title and a real media type.

it likely make no much sense. Refer to manifest.md or so.

manifest.md has title=Manifest, which makes sense, because the JSON it's titling is a manifest. Here, the JSON we're titling is an oci-layout file, so I think we want title=oci-layout%20file.

Copy link
Contributor

@stevvooe stevvooe Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is mediatype=oci%2Dlayout a valid mediatype?

Copy link
Contributor Author

@xiekeyang xiekeyang Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevvooe
Sorry for late response. This is because of https://github.com/opencontainers/image-spec/blob/master/schema/spec_test.go#L70. It means that only those who have mediatype JSON key will be validated. Any arbitrary string here will not influence it to be joined to spec-test function. I use oci-layout, as to close to description in image-layout-schema.json.
If we need a nicer name here?

Copy link
Contributor

@stevvooe stevvooe Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. We should probably note somewhere that this is not a mediatype.

{
"imageLayoutVersion": "1.0.0"
}
Expand Down