Skip to content

Conversation

@vbatts
Copy link
Member

@vbatts vbatts commented Mar 8, 2017

#579 (comment)

Signed-off-by: Vincent Batts [email protected]

@stevvooe
Copy link
Contributor

stevvooe commented Mar 8, 2017

LGTM

Maybe needs to rebase after merging the PR that fixes the build.

Approved with PullApprove

@vbatts vbatts force-pushed the oci-layout-schema branch from 51d01f2 to 90f77c6 Compare March 8, 2017 22:25
@vbatts
Copy link
Member Author

vbatts commented Mar 8, 2017

rebased

@stevvooe
Copy link
Contributor

stevvooe commented Mar 8, 2017

LGTM

Approved with PullApprove

@stevvooe
Copy link
Contributor

stevvooe commented Mar 8, 2017

@jbouzane Pull approve does recognize the approvals system. You need to say "LGTM".

@xiekeyang
Copy link
Contributor

The schema/fs.go might had better to be updated accordingly.

@vbatts
Copy link
Member Author

vbatts commented Mar 9, 2017

@xiekeyang the schema/fs.go is now a PHONY target in the Makefile. It ought to be regenerated as needed for make targets. I wish we could delete the fs.go completely, and only generate it, but that would break go get or vendoring of this spec.

@xiekeyang
Copy link
Contributor

xiekeyang commented Mar 10, 2017

@vbatts Yeah, you are right. I mistook it.

@stevvooe
Copy link
Contributor

LGTM

@jonboulle
Copy link
Contributor

jonboulle commented Mar 13, 2017

👍

Approved with PullApprove

@jonboulle jonboulle merged commit 52d4836 into opencontainers:master Mar 13, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
@vbatts vbatts deleted the oci-layout-schema branch July 19, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants