Skip to content

Optimize output #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhouhao3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize output #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/oci-image-tool/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,12 @@ func createHandle(context *cli.Context) error {

}

return err
if err != nil {
return fmt.Errorf("Creating failed: %v", err)
Copy link
Contributor

@jonboulle jonboulle Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use pkg/errors

}

fmt.Println("Creating succeeded")
Copy link
Contributor

@jonboulle jonboulle Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you really want this output, it should go to stderr, not stdout

return nil
}

var createCommand = cli.Command{
Expand Down
7 changes: 6 additions & 1 deletion cmd/oci-image-tool/unpack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ func unpackHandle(context *cli.Context) error {
err = fmt.Errorf("cannot unpack %q", v.typ)
}

return err
if err != nil {
return fmt.Errorf("Unpacking failed: %v", err)
}

fmt.Println("Unpacking succeeded")
return nil
}

var unpackCommand = cli.Command{
Expand Down