CONTRIBUTING: Remove branch-naming suggestions #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending the earlier softening in 0548361 (CONTRIBUTING: Make leader-issues optional, 2016-05-19, opencontainers#6), because nobody cares about the XXX- prefix. Checking the recent history of all OCI project repos: $ for REPO in image-spec image-tools runc runtime-spec runtime-tools; > do > ( > cd "${REPO} && > git fetch origin && > BRANCHES=$(git log --first-parent --oneline origin/master | sed 's/^.* from //') && > echo "${REPO} branches: $(echo "${BRANCHES}" | wc -l)" && > echo "${REPO} numbered: $(echo "${BRANCHES}" | grep '/[0-9]' | wc -l)" > ); > done image-spec branches: 276 image-spec numbered: 1 image-tools branches: 27 image-tools numbered: 0 runc branches: 1299 runc numbered: 21 runtime-spec branches: 391 runtime-spec numbered: 4 runtime-tools branches: 232 runtime-tools numbered: 3 Signed-off-by: W. Trevor King <[email protected]>
This was referenced Jan 6, 2017
|
LGTM (not sure if I have that authority here) |
Contributor
|
LGTM |
Contributor
Author
|
On Fri, Jan 06, 2017 at 03:50:07PM -0800, Stephen Day wrote:
LGTM (not sure if I have that authority here)
I think the intention is to have the maintainer set for this repo be
the union of all OCI Project maintainer sets [1], although it would be
nice to make that clear with a MAINTAINERS file. I have wording to
that effect in flight with #20 (see a475e76).
The actual team membership tracked by PullApprove, on the other hand,
is a pretty eclectic collection ;) [2]. I'm not sure if anyone is
actually maintaining the tdc-maintainers team or whether or not the
presence of the admin team in .pullapprove.yml is intentional.
[1]: https://github.com/opencontainers/project-template/blob/9f95b15139365f60f27e5cc3028ddad20429a5fe/.pullapprove.yml#L10
[2]: https://pullapprove.com/opencontainers/project-template/pull-request/27/reviews/
|
|
LGTM |
|
LGTM |
Contributor
|
LGTM |
Contributor
Author
|
On Tue, Jan 17, 2017 at 01:50:11PM -0800, Aaron Lehmann wrote:
LGTM
@caniszczyk, it looks like @aaronlehmann is also missing from
@tdc-maintainers (along with @stevvooe [1] and a number of other folks
[2]).
[1]: #27 (comment)
[2]: #27 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the earlier softening in #6, because nobody cares about the
XXX-prefix. Checking the recent history of all OCI project repos:Fixes #26.