CONTRIBUTING: Remove gofmt advice #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all OCI Projects are primarily Go, and filling in off-topic formatting advice doesn't seem useful. One approach to this would be to require projects to support 'make fmt' to handle any auto-formatting. But an easier approach is to keep the document generic in this repository [1], and allow downstream projects to add their own project-specific content as they see fit. I don't expect a lot of churn in this document, so there shouldn't be many conflicts between those downstream changes and further project-template development. [1]: opencontainers#4 (comment) Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun off from #20.
Not all OCI Projects are primarily Go, and filling in off-topic formatting advice doesn't seem useful. One approach to this would be to require projects to support
make fmtto handle any auto-formatting. But an easier approach is to keep the document generic in this repository, and allow downstream projects to add their own project-specific content as they see fit. I don't expect a lot of churn in this document, so there shouldn't be many conflicts between those downstream changes and further project-template development.