Fix panic with config.json with empty process #1848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When config.json does not have a "process" section at all, runc paniced with this error: > panic: runtime error: invalid memory address or nil pointer dereference According to the spec, "process" is optional: https://github.com/opencontainers/runtime-spec/blob/master/config.md#process > process (object, OPTIONAL) specifies the container process. This property is REQUIRED when start is called. So the desired behaviour is: - "runc create": succeed without error - "runc start": return a proper error without panic This patch fixes the panic in "runc create". Further work is needed to allow create but not start. Signed-off-by: Alban Crequy <[email protected]>
Contributor
Member
|
should have been covered in 16d55f1 Feel free to reopen if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When config.json does not have a "process" section at all, runc paniced
with this error:
According to the spec, "process" is optional:
https://github.com/opencontainers/runtime-spec/blob/master/config.md#process
So the desired behaviour is:
This patch fixes the panic in "runc create". Further work is needed to
allow create but not start.
Signed-off-by: Alban Crequy [email protected]