Removing pause state from container errors

[rajasec]

Removing pausing state from error conditions, as container pause(freeze) state of the container

Signed-off-by: Rajasekaran [email protected]

[crosbymichael]

why? this is a valid error, i don't see why to remove this because you cannot start another process in a container that is paused.

[rajasec]

@crosbymichael
While I was doing checkpoint for paused container, it use to freeze for sometime. Once the container is resumed, it will start dumping( not an better analogy).
I thought it will applicable to start of another process too
Also I have seen this error variable is not consumed in the code. Moreover if #218 is part of runc, do we need this error condition. we can give the status to the user saying "Container in paused state"
even when we are killing cgroup processes, we are moving to frozen state ( as per the current impl).So I had an impression that pausing can not be an error condition ( rather it is the state of the container).
May be I'm missing some big picture ?

[crosbymichael]

@rajasec it is an error condition if you are trying to exec another process in a paused container.

i.e.

1. Start container
2. Pause it
   3 . Start another process in container
   4 . Should get the error.

[crosbymichael]

@rajasec in #311 we are actually using the paused error code correctly now so I don't think we need to remove it. Its was just a bug that it was not being consumed.