Skip to content

Allow shared mounts by default #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow shared mounts by default #4652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions libcontainer/rootfs_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,18 @@ func prepareRoot(config *configs.Config) error {
flag := unix.MS_SLAVE | unix.MS_REC
if config.RootPropagation != 0 {
flag = config.RootPropagation
} else {
for _, m := range config.Mounts {
if m.Flags&unix.MS_SHARED != 0 {
// if a mount is using shared, then we don't lock down access with
// slave, instead we just use private so that the submounts can be
// configured shared correctly.
flag = unix.MS_PRIVATE
break
}
}
}

if err := mount("", "/", "", uintptr(flag), ""); err != nil {
return err
}
Expand Down
Loading