Skip to content

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Oct 22, 2025

Fix #1295


This release requires a two-thirds majority maintainers vote (8 of 11).
The voting will close at Tue Nov 4 05:00:00 UTC 2025.

@AkihiroSuda AkihiroSuda added this to the v1.3.0 milestone Oct 22, 2025
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (with or without the freebsd pr)

Copy link
Contributor

@hqhq hqhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kolyshkin
Copy link
Contributor

@tianon @thaJeztah @dqminh PTAL

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wish we'd waited a little longer on FreeBSD, but it's good enough; LGTM

Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor

@thaJeztah @crosbymichael @dqminh PTAL

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 sorry, thought I LGTM'd already, but had the tab still open 😆

LGTM

@utam0k
Copy link
Member

utam0k commented Nov 1, 2025

🎉 The release requirements have been met. 9/11

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Rebased to include

@cyphar
Copy link
Member

cyphar commented Nov 2, 2025

I guess that's fine but technically according to GOVERNANCE the release request is for a specific commit so maybe let's avoid doing that in the future? (It also says that we need to do votes by email, we should probably update that...)

Did you want to prepare the release artefacts @AkihiroSuda?

@AkihiroSuda
Copy link
Member Author

I guess that's fine but technically according to GOVERNANCE the release request is for a specific commit

It seems an "example" "usually"

For example:
> [runtime-spec adopted]: Tag 0647920 as 1.0.0-rc (+6 -0 #3)

runtime-spec/RELEASES.md

Lines 55 to 73 in 6acd32d

Releases usually follow a few steps:
* [ ] prepare a pull-request for the release
* [ ] a commit updating `./ChangeLog`
* [ ] `git log --oneline --no-merges --decorate --name-status v1.0.1..HEAD | vim -`
* [ ] `:% s/(pr\/\(\d*\))\(.*\)/\2 (#\1)/` to move the PR to the end of line and match previous formatting
* [ ] review `(^M|^A|^D)` for impact of the commit
* [ ] group commits to `Additions:`, `Minor fixes and documentation:`, `Breaking changes:`
* [ ] delete the `(^M|^A|^D)` lines, `:%!grep -vE '(^M|^A|^D)'`
* [ ] merge multi-commit PRs (so each line has a `(#num)` suffix)
* [ ] drop hash and indent, `:'<,'> s/^\w* /^I* /`
* [ ] a commit bumping `./specs-go/version.go` to next version and empty the `VersionDev` variable
* [ ] a commit adding back the "+dev" to `VersionDev`
* [ ] send email to [email protected]
* [ ] copy the exact commit hash for bumping the version from the pull-request (since master always stays as "-dev")
* [ ] count the PRs since last release (that this version is tracking, in the cases of multiple branching), like `git log --pretty=oneline --no-merges --decorate $priorTag..$versionBumpCommit | grep \(pr\/ | wc -l`
* [ ] get the date for a week from now, like `TZ=UTC date --date='next week'`
* [ ] OPTIONAL find a cute animal gif to attach to the email, and subsequently the release description
* [ ] subject line like `[runtime-spec VOTE] tag $versionBumpCommit as $version (closes $dateWeekFromNowUTC)`

so maybe let's avoid doing that in the future?

Can we relax this rule?

(It also says that we need to do votes by email, we should probably update that...)

"SHOULD", not "MUST"

A maintainer SHOULD propose a motion on the [email protected] mailing list (except [security issues](#security-issues)) with another maintainer as a co-sponsor.

Did you want to prepare the release artefacts @AkihiroSuda?

Yes

@cyphar
Copy link
Member

cyphar commented Nov 2, 2025

Can we relax this rule?

We can definitely have a discussion about it, but in my view the reason for the rule is to:

  1. Make sure everyone is on the same page about what exactly is being proposed for release.
  2. Avoid situations where someone merges something and includes it in the release without the requisite threshold for approval to end up in a release.

If we feel that these are not practical problems then we can relax this rule, but then it's not clear to me what purpose the 2/3rd majority would serve -- yes, if maintainers object to a release happening at all then it will be blocked, but if they agree to a release then you only need 2 LGTMs to merge something else and rebase the PR. In that case we might as well just only require 2 LGTMs for releases (like we do in runc now) and simply provide an opportunity for other maintainers to voice concerns before we release.

Personally I think the spec repos should be more strict about governance rules than repos like runc and umoci, purely because once we ship something in a spec it is far more permanent than in software projects.

But again, I don't think anyone would object to #1304 being included, this is more of a meta-point about the process.

"SHOULD", not "MUST"

Sure, and I don't mind doing it on GitHub instead but (again) the general flow is meant to be that we have a specific commit we are voting on -- while this information is theoretically provided by GitHub we don't make use of the "dismiss stale reviews" feature in this repo. Obviously if we drop this requirement then this doesn't matter either.

@tianon
Copy link
Member

tianon commented Nov 2, 2025

Agreed/seconded that #1304 is fine and that we should avoid that in the future without resetting the vote.

@utam0k
Copy link
Member

utam0k commented Nov 3, 2025

BTW, who's going to handle preparing the release blog post?

@AkihiroSuda
Copy link
Member Author

BTW, who's going to handle preparing the release blog post?

Shall I write it, or is anybody interested in?

@utam0k
Copy link
Member

utam0k commented Nov 3, 2025

I'm busy this month because I have my wedding 🙏 I might do the next release.

@AkihiroSuda
Copy link
Member Author

I'm busy this month because I have my wedding 🙏 I might do the next release.

Congratulations ㊗️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.3 planning

9 participants