Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Jan 8, 2016

The just-landed style conventions (#287) prefer integers to hex
strings, and I said I'd post an update for this setting if/when those
landed
. The kernel uses uint32s for this setting.

The just-landed style conventions prefer integers to hex strings [1],
and I said I'd post an update for this setting if/when those landed
[2].  The kernel uses uint32s for this setting [3].

[1]: opencontainers#287
[2]: opencontainers#287 (comment)
[3]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/net/cls_cgroup.h?id=refs/tags/v4.3#n24

Signed-off-by: W. Trevor King <[email protected]>
@mrunalp
Copy link
Contributor

mrunalp commented Jan 8, 2016

LGTM

@crosbymichael
Copy link
Member

LGMT

crosbymichael added a commit that referenced this pull request Jan 13, 2016
runtime-config-linux: Convert classID from hex to uint32
@crosbymichael crosbymichael merged commit ad6092e into opencontainers:master Jan 13, 2016
@wking wking deleted the integer-classID branch January 22, 2016 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants