Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Jan 27, 2016

With 34a9304a (Merge branch 'for-4.5' of
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup, 2016-01-13),
Linux restructured their cgroups documentation. This updated all of
our Documentation/cgroups references to match the new layout, using
reference-style links which let us collect link label definitions
at the bottom of the file. That makes the spec source easier to read
(no distracting URLs in the middle of a sentence) and makes the URLs
easier to update (only one place to check / fix).

This builds on #298, so that PR should land first.

config-linux.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the fields required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Wed, Jan 27, 2016 at 12:44:58PM -0800, Vish Kannan wrote:

Are all the fields required?

The change's you are commenting on are part of #298 1. If you want
to review this PR before #298 lands, you probably just want to look at
the tip commit 2.

@wking
Copy link
Contributor Author

wking commented Jan 27, 2016

I just pushed a722d3201e5ed1 fixing a cgroups-devicescgroup-v1-devices label.

@wking
Copy link
Contributor Author

wking commented Jan 28, 2016

Pushed 01e5ed122e2e3b now that #298 has landed.

With 34a9304a (Merge branch 'for-4.5' of
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup, 2016-01-13,
[1]), Linux restructured their cgroups documentation.  This updated
all of our Documentation/cgroups references to match the new layout,
using reference-style links [2] which let us collect link label
definitions at the bottom of the file.  That makes the spec source
easier to read (no distracting URLs in the middle of a sentence) and
makes the URLs easier to update (only one place to check / fix).

[1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34a9304a96d6351c2d35dcdc9293258378fc0bd8
[2]: http://daringfireball.net/projects/markdown/syntax#link

Signed-off-by: W. Trevor King <[email protected]>
@wking
Copy link
Contributor Author

wking commented Jan 28, 2016

Pushed 22e2e3b1b0056c fixing the wrong URL for cgroup-v2.

@hqhq
Copy link
Contributor

hqhq commented Jan 28, 2016

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Feb 4, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Feb 4, 2016
config-linux: Update links to cgroups documentation
@mrunalp mrunalp merged commit 80322b9 into opencontainers:master Feb 4, 2016
@wking wking deleted the cgroup-v1-links branch March 3, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants