Skip to content

config: Move (u|g)idMappings from 'process' to 'linux' #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2016
Merged

config: Move (u|g)idMappings from 'process' to 'linux' #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,20 +286,6 @@ Here is a full example `config.json` for reference.
6
]
},
"uidMappings": [
{
"hostID": 1000,
"containerID": 0,
"size": 32000
}
],
"gidMappings": [
{
"hostID": 1000,
"containerID": 0,
"size": 32000
}
],
"args": [
"sh"
],
Expand Down Expand Up @@ -463,6 +449,20 @@ Here is a full example `config.json` for reference.
"gid": 0
}
],
"uidMappings": [
{
"hostID": 1000,
"containerID": 0,
"size": 32000
Copy link
Contributor

@hqhq hqhq Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32000 looks like a non sense magic number, 32768 might be better, what do you think?

Copy link
Contributor Author

@wking wking Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Wed, Apr 20, 2016 at 07:23:00PM -0700, Qiang Huang wrote:

@@ -463,6 +449,20 @@ Here is a full example config.json for reference.
"gid": 0
}
],

  •    "uidMappings": [

  •        {

  •            "hostID": 1000,

  •            "containerID": 0,

  •            "size": 32000

32000 looks like a non sense magic number, 32768 might be better, what do you think?

This PR is just about moving the existing example to the right place,
not about adjusting the example content.

If you want to file a separate issue/PR adjusting the number, that
size is from #370 based on @mrunalp's “32k” suggestion 1. I'm happy
with anything > 0 and still well short of overflowuid.

Copy link
Contributor

@hqhq hqhq Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK if we do this in a separate PR, I think 32k is supposed to be 32768.

}
],
"gidMappings": [
{
"hostID": 1000,
"containerID": 0,
"size": 32000
}
],
"sysctl": {
"net.ipv4.ip_forward": "1",
"net.core.somaxconn": "256"
Expand Down