Skip to content

Conversation

@vbatts
Copy link
Member

@vbatts vbatts commented Apr 27, 2016

Fixes #398

This produces a markdown page as a header for the PDF and HTML pages.

Signed-off-by: Vincent Batts [email protected]

@wking
Copy link
Contributor

wking commented Apr 27, 2016

On Wed, Apr 27, 2016 at 07:54:30AM -0700, Vincent Batts wrote:
“ A .tool/version-doc.go (25)”

This is depressingly large when an inline:

$ sed -n 's/."ociVersion": *"([^"])",/Specification Version: \1/p' config.md

would do the same thing (assuming we update the example 1). But
maybe relying on Go is more portable than relying on sed? On the
other hand, systems that have ‘make’ are likely to have ‘sed’.

Aside from that minor grump, 73ef76d looks good to me.

@crosbymichael
Copy link
Member

LGTM

plz rebase

@vbatts vbatts merged commit 4941dba into opencontainers:master May 2, 2016
@vbatts vbatts deleted the version_page branch May 2, 2016 18:12
@wking wking mentioned this pull request May 7, 2016
Mashimiao pushed a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants