config-linux: Make “don't modify filesystem permissions” generic #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user-namespace restriction isn't about the root filesystem in particular. For example, if you bind mount in a second filesystem, the runtime shouldn't adjust ownership on that filesystem either. I've also adjusted the old "permissions" to "ownership", since that more clearly reflects the fields (user and group) that you would modify if you wanted to adjust for user namespacing. Signed-off-by: W. Trevor King <[email protected]>
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user-namespace restriction isn't about the root filesystem in particular. For example, if you bind mount in a second filesystem, the runtime shouldn't adjust ownership on that filesystem either.
I've also adjusted the old “permissions” to “ownership”, since that more clearly reflects the fields (user and group) that you would modify if you wanted to adjust for user namespacing.
This nibbles some more ground-work off from #423, since that approach worked well in #435.