Skip to content

Conversation

@jcfr
Copy link

@jcfr jcfr commented Jun 16, 2016

Fix regression respectively introduced in 59ede1a and 59ede1a

Signed-off-by: Jean-Christophe Fillion-Robin [email protected]

Fix regression respectively introduced in 59ede1a and 59ede1a

Signed-off-by: Jean-Christophe Fillion-Robin <[email protected]>
@jcfr jcfr force-pushed the fix-readme-schema-links branch from 5b15215 to 2de2019 Compare June 16, 2016 21:11
@jcfr jcfr changed the title schema/README: Fix link to (config|state)-schema.json schema/README: Fix links to (config|state)-schema.json Jun 16, 2016
@jcfr
Copy link
Author

jcfr commented Jun 16, 2016

xref #498

@jcfr
Copy link
Author

jcfr commented Jun 16, 2016

Cc: @wking

@jcfr
Copy link
Author

jcfr commented Jun 16, 2016

Et voila 😄

@wking
Copy link
Contributor

wking commented Jun 16, 2016

2de2019 looks good to me (and you could have force pushed to your
patch-1 branch to update #500).

I don't know whether #498 should be held open for some time to give
@leecalcote a chance to sign his commit, but he's been quiet so far
and this is a small change, so I doubt he'd mind if this PR landed and
scooped him ;).

@jcfr
Copy link
Author

jcfr commented Jun 16, 2016

force pushed to your patch-1 branch

Indeed, will do if such situation occurs again

held open for some time

Makes sense.

Cc: @leecalcote

@leecalcote
Copy link
Contributor

I'm happy to update my commit. Just tell me what needs to be done. A git commit --amend?

@wking
Copy link
Contributor

wking commented Jun 16, 2016

On Thu, Jun 16, 2016 at 03:20:40PM -0700, Lee Calcote wrote:

I'm happy to update my commit. Just tell me what needs to be done. A
git commit --amend?

Something like:

$ git checkout patch-1
$ git commit --amend --signoff --no-edit
$ git push --force leecalcote patch-1

will update #498. But you'll want to make sure you're ok with what
you're signing first 1 ;).

@leecalcote
Copy link
Contributor

Thanks @wking. I think #498 is good to go now.

@jcfr
Copy link
Author

jcfr commented Jun 17, 2016

Nice. Closing this PR .. it is superseded by #498

@jcfr jcfr closed this Jun 17, 2016
@jcfr jcfr deleted the fix-readme-schema-links branch June 17, 2016 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants