Skip to content

Add references to Windows containers #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add references to Windows containers #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa909c
[ReadMe] Add references to Windows containers
RobDolinMS Sep 1, 2016
d407660
[Config-Windows] Create file
RobDolinMS Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Table of Contents
- [General Configuration](config.md)
- [Linux-specific Configuration](config-linux.md)
- [Solaris-specific Configuration](config-solaris.md)
- [Windows-specific Configuration](config-windows.md)
- [Glossary](glossary.md)

In the specifications in the above table of contents, the keywords "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" are to be interpreted as described in [RFC 2119](http://tools.ietf.org/html/rfc2119) (Bradner, S., "Key words for use in RFCs to Indicate Requirement Levels", BCP 14, RFC 2119, March 1997).
Expand All @@ -31,6 +32,7 @@ An implementation that satisfies all the MUST or REQUIRED and all the SHOULD req
Protocols defined by this specification are:
* Linux containers: [runtime.md](runtime.md), [config.md](config.md), [config-linux.md](config-linux.md), and [runtime-linux.md](runtime-linux.md).
* Solaris containers: [runtime.md](runtime.md), [config.md](config.md), and [config-solaris.md](config-solaris.md).
* Windows containers: [runtime.md](runtime.md), [config.md](config.md), and [config-windows.md](config-windows.md).

# Use Cases

Expand Down
3 changes: 3 additions & 0 deletions config-windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Windows Application Container Configuration

Windows application containers can be configured using the following properties.
Copy link
Contributor

@wking wking Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the meat? Is this supposed to have stuff from #504?

Copy link
Collaborator Author

@RobDolinMS RobDolinMS Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking To your question of "Where's the beef", there's not much here yet. I would expect that #504 and similar would be added over time. My desire with this PR it clear that it is the intent of OCI to support Linux, Solaris, and Windows.

Copy link
Contributor

@wking wking Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Thu, Sep 01, 2016 at 04:11:39PM -0700, Rob Dolin (MSFT) wrote:

@@ -0,0 +1,3 @@
+# Windows Application Container Configuration
+
+Windows application containers can be configured using the following properties.

… My desire with this PR it clear that it is the intent of OCI to
support Linux, Solaris, and Windows.

Then how about dropping this file (until you have Windows-specific
settings to put into it) and using:

in README.md?