Skip to content

Require the mount destination to be created before hand #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Require the mount destination to be created before hand #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ The parameters are similar to the ones in [the Linux mount system call](http://m

* **`destination`** (string, REQUIRED) Destination of mount point: path inside container.
For the Windows operating system, one mount destination MUST NOT be nested within another mount (e.g., c:\\foo and c:\\foo\\bar).
The destination MUST be present in the root filesystem. Runtime MUST NOT create the destination.
Copy link
Contributor

@wking wking Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Runtime” → “The runtime”.

Copy link
Contributor

@wking wking Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, one sentence per line.

Copy link
Member

@cyphar cyphar Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just make this a restriction which only applies if readonly is set to true for the rootfs. I get why you'd want a sweeping statement like this, but as @wking mentioned it does make nested tmpfs mounts quite hard -- and in fact would make runC's method of handling cgroups not really possible anymore.

Copy link
Member

@cyphar cyphar Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the "MUST be present in the root filesystem" means that you can't really have nested tmpfs mounts anyway. Because /tmp/a/b must already have existed in the host root filesystem in order for you to mount it (which would require making the directory). Maybe we should make it something like:

The destination MUST already be present if the destination mountpoint is on the root filesystem.
Runtimes MUST NOT modify the container's root filesystem to fulfil destination requirements.

* **`type`** (string, REQUIRED) The filesystem type of the filesystem to be mounted.
Linux: *filesystemtype* argument supported by the kernel are listed in */proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs", "reiserfs", "msdos", "proc", "nfs", "iso9660").
Windows: ntfs.
Expand Down