Skip to content

config.md: clarify timeout of hooks is OPTIONAL #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

config.md: clarify timeout of hooks is OPTIONAL #604

wants to merge 1 commit into from

Conversation

@coolljt0725
Copy link
Member

@coolljt0725 coolljt0725 commented Oct 28, 2016

Signed-off-by: Lei Jitang [email protected]

wking
wking reviewed Oct 28, 2016
View reviewed changes
config.md

`path` is REQUIRED for a hook.
`args` and `env` are OPTIONAL.
`args`, `env` and `timeout` are OPTIONAL.
Copy link
Contributor

@wking wking Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also covered by #427 which cleans up a lot of other hook spec too.

Copy link
Member Author

@coolljt0725 coolljt0725 Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking didn't find that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coolljt0725 @wking