Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Nov 10, 2016

This happened in #574 but was accidentally rolled back in #518.

This happened in c35cf57 (config: Replace "optional" with "OPTIONAL",
2016-09-17, opencontainers#574) but was accidentally rolled back in 52f3cde
(Clarify wording for terminal setting and /dev/console, 2016-07-18,
opencontainers#518).

Signed-off-by: W. Trevor King <[email protected]>
@mrunalp
Copy link
Contributor

mrunalp commented Nov 14, 2016

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Nov 15, 2016

LGTM

Approved with PullApprove

@hqhq hqhq merged commit b69dcba into opencontainers:master Nov 15, 2016
@wking wking deleted the process.terminal-optional-case branch November 16, 2016 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants