schema: fix items based on latest spec #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ma Shimiao <[email protected]>
Contributor
|
LGTM |
wking
reviewed
Jan 13, 2017
Contributor
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
The same “we probably don't want to allow explicit null” applies to UID and GID too, and probably a bunch of other settings in the JSON Schema as well. I'm fine addressing this in a follow-up PR if you don't want to handle it here.
| }, | ||
| "kernelTCP": { | ||
| "id": "https://opencontainers.org/schema/bundle/linux/resources/memory/kernelTCP", | ||
| "$ref": "defs.json#/definitions/int64Pointer" |
Contributor
There was a problem hiding this comment.
Contributor
|
LGTM |
Collaborator
|
@wking Can your comment be addressed in a separate PR? |
Member
|
LGTM |
This was referenced Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]