schema/test/config/good/minimal: Drop 'process' #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think minimal should reflect a normal full flow with start and should have a process section. |
Contributor
Author
Can I just add another for that? |
Contributor
|
Yeah, that works for me. |
It's optional since c41ea83 (config: Make process optional, 2017-02-27, opencontainers#701) which landed yesterday. Mrunal wanted to continue testing a config which has enough for a 'start' invocation [1], so I've kept the old JSON as minimal-for-start.json (washing it through 'make -C schema fmt' to adjust the args indenting). [1]: opencontainers#805 (comment) Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
schema-test-optional-process
branch
from
9b2daa5 to
90423a0
Compare
Contributor
Author
mrunalp
approved these changes
May 12, 2017
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's optional since #701 which landed yesterday.