generate: Set process.args to an empty array if it was nil #59

wking · 2016-05-07T04:56:30Z

Before this commit:

$ ocitools generate --template <(echo '{}')
$ grep args config.json
    "args": null,

With this commit:

$ grep args config.json
    "args": [],

That's still not a particularly useful value for the process
arguments, but it complies with the specs “array of strings”
typing (opencontainers/runtime-spec#416) and is closer to a
the useful entry (a non-empty array).

Before this commit: $ ocitools generate --template <(echo '{}') $ grep args config.json "args": null, With this commit: $ grep args config.json "args": [], That's still not a particularly useful value for the process arguments, but it complies with the specs "array of strings" typing [1] and is closer to a useful entry (a non-empty array). [1]: https://github.com/opencontainers/runtime-spec/blob/dbce512cec0cd0774b236980ec18a4f6a91bc77e/config.md#process-configuration Signed-off-by: W. Trevor King <[email protected]>

mrunalp · 2016-05-10T19:31:29Z

LGTM

wking force-pushed the empty-array-default-for-process.args branch from 45256e1 to 1066a92 Compare May 7, 2016 04:57

mrunalp merged commit ecb4e48 into opencontainers:master May 10, 2016

wking deleted the empty-array-default-for-process.args branch May 13, 2016 23:51

Provide feedback