*: support platform variants#640
Merged
cyphar merged 7 commits intoopencontainers:mainfrom Oct 15, 2025
Merged
Conversation
cyphar
force-pushed
the
platform-variant
branch
from
e3169b4 to
7e85f12
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 72.89% 72.94% +0.05%
==========================================
Files 71 71
Lines 6164 6181 +17
==========================================
+ Hits 4493 4509 +16
- Misses 1213 1214 +1
Partials 458 458
🚀 New features to boost your workflow:
|
cyphar
force-pushed
the
platform-variant
branch
from
7e85f12 to
282d4d9
Compare
This applies to both the Go API (breaking) and "umoci config" CLI (with backward-compatible aliases). The main reason is that now that v1.1 of the image-spec decided to properly refactor the platform configuration into a separate structure, it makes sense for us to refer to it that way in our own APIs. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
These tests were disabled back in 2017 because of image-spec and runtime-spec changes, but those changes have long since been resolved. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
The image-spec conversion specification requires that config.Labels take precedence over the auto-generated values from the rest of the configuration, but our code implmented it the other way around. While we're at it, don't generate annotations for fields that are zeroed. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This is still quite manual, but it does at least provide the necessary feature for ARM. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
We generally need to specify the variant of the architecture if we are running on ARM. Rather than reimplementing /proc/cpuinfo parsing, just use containerd's platform parser since that is the standard thing used by most container tools. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
platform-variant
branch
from
282d4d9 to
0242283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313
Signed-off-by: Aleksa Sarai cyphar@cyphar.com