fix: ignored alloc keys does not drop pvs and lbAllocations#29
Open
ricjsan wants to merge 1 commit intoopencost:mainfrom
Open
fix: ignored alloc keys does not drop pvs and lbAllocations#29ricjsan wants to merge 1 commit intoopencost:mainfrom
ricjsan wants to merge 1 commit intoopencost:mainfrom
Conversation
Signed-off-by: Ricardo <159469490+ricjsan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated parquet still includes pvcs.
Digging through the code I could see that
ignored_alloc_keysis not correctly initialized since the array is never retrieved from thekeysproperty.ignore_alloc_keys.json:
{ "keys": ["pvs", "lbAllocations"] }opencost_parquet_exporter.py: