Skip to content

add missing cudaFree #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

add missing cudaFree #3999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53c8405
add cudaFree d_counter to avoid memory leak
incubus-ank Sep 10, 2025
3f97acf
Moved cudaMalloc() and cudaFree() to the constructor and destructor t…
incubus-ank Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions modules/cudafeatures2d/src/fast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ namespace
{
public:
FAST_Impl(int threshold, bool nonmaxSuppression, int max_npoints);
~FAST_Impl();

virtual void detect(InputArray _image, std::vector<KeyPoint>& keypoints, InputArray _mask);
virtual void detectAsync(InputArray _image, OutputArray _keypoints, InputArray _mask, Stream& stream);
Expand Down Expand Up @@ -95,6 +96,12 @@ namespace
FAST_Impl::FAST_Impl(int threshold, bool nonmaxSuppression, int max_npoints) :
threshold_(threshold), nonmaxSuppression_(nonmaxSuppression), max_npoints_(max_npoints)
{
cudaSafeCall( cudaMalloc(&d_counter, sizeof(unsigned int)) );
}

FAST_Impl::~FAST_Impl()
{
cudaSafeCall( cudaFree(d_counter) );
}

void FAST_Impl::detect(InputArray _image, std::vector<KeyPoint>& keypoints, InputArray _mask)
Expand All @@ -116,8 +123,6 @@ namespace
{
using namespace cv::cuda::device::fast;

cudaSafeCall( cudaMalloc(&d_counter, sizeof(unsigned int)) );

const GpuMat img = _image.getGpuMat();
const GpuMat mask = _mask.getGpuMat();

Expand Down Expand Up @@ -165,8 +170,6 @@ namespace
kpLoc.colRange(0, count).copyTo(locRow, stream);
keypoints.row(1).setTo(Scalar::all(0), stream);
}

cudaSafeCall( cudaFree(d_counter) );
}

void FAST_Impl::convert(InputArray _gpu_keypoints, std::vector<KeyPoint>& keypoints)
Expand Down
Loading