-
Notifications
You must be signed in to change notification settings - Fork 260
Migrating the EfficientSAM model to the OpenCV model zoo #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fengyuentau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution! Please have a look at my comments below.
models/image_segmentation_efficientsam/examples/examples_image1.jpg
Outdated
Show resolved
Hide resolved
| EfficientSAM: Leveraged Masked Image Pretraining for Efficient Segment Anything | ||
|
|
||
| Notes: | ||
| - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original repo offers EfficientSAM-S and -Ti. Which one is used here? Add a note to describe including version (shasum, md5sum, etc.). Also describe how you convert the model to ONNX (a script would be nice).
Also need to describe how many clicks are required.
WanliZhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job👍! Thanks for your contribution. You can check the comment I left. BTW, the benchmark and quantized model part is expected if possible.
|
now this pr is only about model and demo, no benchmark |
fengyuentau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the following issue and we are going to merge this PR for 4.10.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop changes in file for now as it affects the benchmark.
WanliZhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
EfficientSAM Model Demonstration
I have successfully written the code for the EfficientSAM model and created an interactive demo that enables normal model inference and user interaction. Users can easily use this demo via the command line with the following command:
By simply providing the path to the image they wish to segment, the demo will display the image. Upon clicking the object they want to segment in the image, a new window will show the segmentation result, making it user-friendly and straightforward.
Example
Please note that the current model inference speed takes approximately 2 seconds. The camera demo is not yet completed, and I plan to optimize it and add camera functionality in the future.
Performance Testing
The model's benchmark testing has not been conducted yet. I will perform the tests in the future and provide the relevant performance data.
Thank you for your attention. I will continue to update and optimize the EfficientSAM model and its demonstration.