test: extend CUDA test suite for PyTorch packages and CUDA_HOME#83
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds four tests to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/test_cuda_image.py`:
- Around line 108-109: The assertion message in tests/test_cuda_image.py (the
assert on variable result from cuda_container.run("ldconfig -p | grep
libcusparseLt")) exceeds the 100-char line limit; shorten or wrap the message so
the line length is <=100 characters (for example, shorten the message text or
move part of it to a variable) while preserving the assertion and meaning that
libcusparseLt.so may be missing if returncode != 0.
Add tests to validate the packages from opendatahub-io#70 and env var from opendatahub-io#69: - CUDA_HOME env var equals /usr/local/cuda - libcupti.so present (cuda-cupti package) - libcusparseLt.so present (libcusparselt0 package) - libcudss.so present (libcudss0-cuda package) Closes opendatahub-io#74 Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>
30e6659 to
56db1fc
Compare
Add tests to validate the packages from #70 and env var from #69:
Closes #74
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit