Pin openshift-golang-builder to 1.23 rhel8 tag #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/konflux-2.16 Review Dockerfile and RPMs file for building odh-codeflare-operator in konflux
…s/konflux-2.16 add renovate.json config
…s/update-renovate Update renovate.json for 2.16
…-builder Docker digest to 2e38fae Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
…s/MohammadiIram-patch-1 Update Dockerfile.konflux
…12e67a Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
…s/MohammadiIram-patch-2 Update Dockerfile.konflux with tag+digest
…s/MohammadiIram-patch-3 Update Golang builder image to use brew.registry.redhat.io
…to 5c10b78 Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
…to 10fa6a0 Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
…to cf4d4d3 Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: konflux-internal-p02 <126015336+konflux-internal-p02[bot]@users.noreply.github.com>
In 4f3ee0f, 1.23 was introduced, but just referenced by manifest digest. Unfortunately the Konflux bot appears to have assumed that it was the `latest` tag, and saw a "new" (read: several years old) digest for that tag, and bumped to it in 3798127. This change specifies the rhel_8_golang_1.23 tag, so that it will only bump to newer versions of _that_ tag. This change also changes the registry domain to be brew.registry.redhat.io, since 68487ea (red-hat-data-services#194) appears to indicate that that's preferred/required for Konflux. One can use the `--build-arg` CLI option to use the registry-proxy locally as needed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Sorry, wrong target repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4f3ee0f, 1.23 was introduced, but just referenced by manifest
digest. Unfortunately the Konflux bot appears to have assumed that it
was the
latesttag, and saw a "new" (read: several years old) digestfor that tag, and bumped to it in 3798127.
This change specifies the rhel_8_golang_1.23 tag, so that it will only
bump to newer versions of that tag.
This change also changes the registry domain to be
brew.registry.redhat.io, since 68487ea (project-codeflare#194) appears to indicate that
that's preferred/required for Konflux. One can use the
--build-argCLI option to use the registry-proxy locally as needed.