NO-JIRA: Fix konflux quay reference#88
Conversation
WalkthroughThe change updates the Tekton pipeline configuration by modifying the output image parameter in the PipelineRun specification. Specifically, it changes the container image repository path, removing the "odh-" prefix from the image name. No other logic or configuration changes are introduced. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
/overwrite ci/prow/e2e-odh-cfo |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/overwrite ci/prow/e2e-odh-cfo |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.tekton/odh-codeflare-operator-push.yaml (1)
27-30: Confirm registry permissions & keep metadata in sync with the new repo pathThe change switches the target image from
quay.io/opendatahub/odh-codeflare-operatortoquay.io/opendatahub/codeflare-operator.
Please verify two follow-ups:
- The service-account
build-pipeline-odh-codeflare-operatorstill has push rights to the new repository path.- Labels / names that still include
odh-codeflare-operator(e.g.metadata.name,metadata.labels.component) are intentional; otherwise consider renaming for consistency:- name: odh-codeflare-operator-on-push - appstudio.openshift.io/component: odh-codeflare-operator + name: codeflare-operator-on-push # optional + appstudio.openshift.io/component: codeflare-operator # optionalNeglecting (1) will cause the PipelineRun to fail during the push step.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.tekton/odh-codeflare-operator-push.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build
- GitHub Check: precommit
- GitHub Check: build
|
/override ci/prow/e2e-odh-cfo |
|
@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: ci/prow/e2e-odh-cfo, ci/prow/images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit