Skip to content

Conversation

@anishasthana
Copy link
Member

Closes #101

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anishasthana. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anishasthana
Copy link
Member Author

/retest


## Setup

You can follow the instructions in the [base readme](../README.md) to install the Distributed Workolads stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can follow the instructions in the [base readme](../README.md) to install the Distributed Workolads stack.
You can follow the instructions in the [base readme](../README.md) to install the Distributed Workloads stack.

"runtime_env = {\"pip\": [\"transformers\", \"datasets\", \"evaluate\", \"pyarrow<7.0.0\", \"accelerate\"]}\n",
"\n",
"# NOTE: This will work for in-cluster notebook servers (RHODS/ODH), but not for local machines\n",
"# To see how to connect from your laptop, go to demo-notebooks/additional-demos/local_interactive.ipynb\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook is not in this repo. We should use the complete url

Suggested change
"# To see how to connect from your laptop, go to demo-notebooks/additional-demos/local_interactive.ipynb\n",
"# To see how to connect from your laptop, go to https://github.com/project-codeflare/codeflare-sdk/blob/main/demo-notebooks/additional-demos/local_interactive.ipynb\n",

kryanbeane pushed a commit to kryanbeane/distributed-workloads that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tutorial using KubeRay alongside ODH

2 participants