Skip to content

Adjust SDK TransfomersTrainer e2e tests for Trainer v2 to work in disconnected environment #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abhijeet-dhumal wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adjust SDK TransfomersTrainer e2e tests for Trainer v2 to work in disconnected environment #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/trainer/kubeflow_sdk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,35 @@ func TestRhaiFeaturesRocm(t *testing.T) {
Tags(t, KftoRocm, MultiNodeGpu(2, support.AMD))
sdktests.RunRhaiFeaturesAllTest(t, support.AMD)
}

// Multi-GPU CUDA tests - 2 nodes, 2 GPUs each (requires 4 total NVIDIA GPUs)
func TestRhaiTrainingProgressionMultiGpuCuda(t *testing.T) {
Copy link
Contributor

@sutaakar sutaakar Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to test separately multinode single GPU and multinode multi GPU?
how much time does it take to run one test?

Copy link
Contributor

@sutaakar sutaakar Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the new model downloading implementation is quite slow, downloading from HuggingFace

Tags(t, KftoCuda, MultiNodeMultiGpu(2, support.NVIDIA, 2))
sdktests.RunRhaiFeaturesProgressionMultiGpuTest(t, support.NVIDIA, 2, 2)
}

func TestRhaiJitCheckpointingMultiGpuCuda(t *testing.T) {
Tags(t, KftoCuda, MultiNodeMultiGpu(2, support.NVIDIA, 2))
sdktests.RunRhaiFeaturesCheckpointMultiGpuTest(t, support.NVIDIA, 2, 2)
}

func TestRhaiFeaturesMultiGpuCuda(t *testing.T) {
Tags(t, KftoCuda, MultiNodeMultiGpu(2, support.NVIDIA, 2))
sdktests.RunRhaiFeaturesAllMultiGpuTest(t, support.NVIDIA, 2, 2)
}

// Multi-GPU ROCm tests - 2 nodes, 2 GPUs each (requires 4 total AMD GPUs)
func TestRhaiTrainingProgressionMultiGpuRocm(t *testing.T) {
Tags(t, KftoRocm, MultiNodeMultiGpu(2, support.AMD, 2))
sdktests.RunRhaiFeaturesProgressionMultiGpuTest(t, support.AMD, 2, 2)
}

func TestRhaiJitCheckpointingMultiGpuRocm(t *testing.T) {
Tags(t, KftoRocm, MultiNodeMultiGpu(2, support.AMD, 2))
sdktests.RunRhaiFeaturesCheckpointMultiGpuTest(t, support.AMD, 2, 2)
}

func TestRhaiFeaturesMultiGpuRocm(t *testing.T) {
Tags(t, KftoRocm, MultiNodeMultiGpu(2, support.AMD, 2))
sdktests.RunRhaiFeaturesAllMultiGpuTest(t, support.AMD, 2, 2)
}
Loading
Loading