Skip to content

Sync dev branch into release branch#1218

Merged
pierDipi merged 45 commits intoopendatahub-io:release-v0.17from
spolti:relSync
Mar 17, 2026
Merged

Sync dev branch into release branch#1218
pierDipi merged 45 commits intoopendatahub-io:release-v0.17from
spolti:relSync

Conversation

@spolti
Copy link
Member

@spolti spolti commented Mar 17, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Feature/Issue validation/testing:

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?
  • Have you linked the JIRA issue(s) to this PR?

Release note:


bartoszmajsak and others added 30 commits March 11, 2026 18:09
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…e#5233)

Signed-off-by: Jooho Lee <jlee@redhat.com>

It only updates cherry-pick gitaction
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…e#5217)

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…kserve#5180)

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
… int32 (kserve#5237)

Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>
…pendatahub-io#1189)

Users with edit/view roles cannot list or manage LLMInferenceServiceConfigs
because the resource was missing from the kserve-edit and kserve-view
ClusterRoles.

Signed-off-by: Killian Golds <kgolds@redhat.com>
…ve#5154)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
…kserve#5194)

Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…serve#5242)

Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>
Signed-off-by: Filippe Spolti <fspolti@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
Co-authored-by: Jooho Lee <jlee@redhat.com>
…on (kserve#5246)

Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>
Commits included in this batch:
c1d24e5 (community/master, community/HEAD, community-master) test(llmisvc): add envtest integration tests for scaling reconciliation (kserve#5246)
3fab6f7 fix: to install specific kserve version with kustomize script (kserve#5247)
55f7afd fix: change wrong crd kustomization update (kserve#5234)
dbaff63 fix(llmisvc): add missing os.Exit(1) after controller setup failure (kserve#5242)
5270d1f feat: add storage migration for LLMinferenceService APIs (kserve#5149)
6a9f524 feat(llmisvc): implement autoscaling for WVA and KEDA/HPA integration (kserve#5194)
8f0a110 feat: merge target branch in each GH action job (kserve#5232)
ba4a28b feat(llmisvc): add --disable-uvicorn-access-log to vllm configs (kserve#5154)
0c3c178 fix(llmisvc): add default for MinReplicas & make MaxReplicas required int32 (kserve#5237)
ba94e0b feat:  upgrade llm-d to 0.6 (kserve#5121)
7b43cc0 feat: allow configuring GatewayClass for llmisvc e2e tests (kserve#5238)
90447b7 fix(build): fall back to existing version when URL verification fails (kserve#5180)
2983b3f fix: resolve `go test -cover` failure (kserve#5178)
df95fcd test(llmisvc): unit tests for versioned config resolution (kserve#5182)
3f169a7 feat(llmisvc): add build hooks for distribution-specific logic (kserve#5217)
d8589e5 chore: bump kustomize from v5.5.0 to v5.8.0 (kserve#5218)
db9e355 fix: improve cherry-pick workflow with validation and PR fetch (kserve#5233)
fb09d22 fix(make): increase test timeout from 20m to 30m (kserve#5165)
* Remove `runAsUser: 1000` on the llmisvc-controller, to be compatible
  with OpenShift.
* Correctly apply llmisvc-controller image specified in params.env file.
* Port missing inferenceservice-config ConfigMap patches from `release-v0.15`
  branch.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>

# Conflicts:
#	config/overlays/odh/kustomization.yaml
fix: add git user config to github bot

Signed-off-by: Spolti <fspolti@redhat.com>
…ahub-io#1194)

The Spyre operator on s390x enforces schedulerName: spyre-scheduler on
all pods using ibm.com/spyre_vf via a ValidatingWebhookConfiguration.
Without this field, the llmisvc-controller's generated Deployments are
rejected by the admission webhook.

Add schedulerName: spyre-scheduler at the pod spec level so it gets
deep-copied into the generated Deployment.

Reported-by: Deepali Kushwah

Signed-off-by: Killian Golds <kgolds@redhat.com>
…template (opendatahub-io#1200)

IBM Spyre team has removed /etc/profile.d/ibm-aiu-setup.sh from their
images, making the conditional sourcing dead code. Remove it from the
bash wrapper while preserving the  args forwarding pattern from
kserve#5049.

Signed-off-by: Killian Golds <kgolds@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Killian Golds <kgolds@redhat.com>
* Add xKS overlay to master

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix build command

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix: wait for CRDs

The kubectl wait --for=condition=Established fails because the CRD's
`.status.conditions` is `nil`

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Apply llmisvc CRDs

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix: only remove existing SCC

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* add namespace

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update xks overlay patch

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix separate webhook

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* cleanup

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Include GIE CRDs

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* poetry -> uv + review comments

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* distro arg

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Use Makefile target for building image

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix: uv sync

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix: pass distro build tags to controller-gen for RBAC generation

controller-gen does not respect GOFLAGS for build tags, so kubebuilder
RBAC markers in //go:build distro files (e.g. Istio DestinationRules)
were not included in the generated ClusterRole. This caused the
llmisvc-controller-manager to fail with "destinationrules is forbidden"
errors at runtime.

Fix by adding --load-build-tags support via CONTROLLER_GEN_BUILD_TAGS
and loading Makefile.overrides.mk early so the variable is set before
the ifdef checks.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* CA secret in cache

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Revert "fix: pass distro build tags to controller-gen for RBAC generation"

This reverts commit 45556fc.

* fix: CSR is not present

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update RBAC

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* configure GatewayClass

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Exclude custom gateways

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* distro by default

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Generate

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* fix: tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add CA signing key

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add istio CRD

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Ignore not exits

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* GOFLAGS in overrides

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…erve#5251)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi and others added 6 commits March 16, 2026 22:44
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…-upstream-odh

Sync 260313 kserve upstream odh
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ede86b7a-56df-4567-a32b-f60f53adf095

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

@spolti spolti added do-not-merge/hold tide/merge-method-merge Change lgtm to use a merge commit and removed approved labels Mar 17, 2026
)

This prevents the scheduler from restarting when upgrading.

Related to https://github.com/kserve/kserve/pull/5260/changes

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member

can we include #1217?

@spolti spolti changed the title Rel sync Sync dev branch into release branch Mar 17, 2026
@spolti
Copy link
Member Author

spolti commented Mar 17, 2026

Done.

@spolti
Copy link
Member Author

spolti commented Mar 17, 2026

/test

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

@spolti: No presubmit jobs available for opendatahub-io/kserve@release-v0.17

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/override ci/prow/images

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi pierDipi merged commit dee4213 into opendatahub-io:release-v0.17 Mar 17, 2026
26 of 27 checks passed
@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants