-
Notifications
You must be signed in to change notification settings - Fork 37
[RHOAIENG-30228] add-http-route-conditions #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-30228] add-http-route-conditions #827
Conversation
Signed-off-by: Andres Llausas <[email protected]>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Andres Llausas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments
Signed-off-by: Andres Llausas <[email protected]>
Signed-off-by: Andres Llausas <[email protected]>
… RHOAIENG-30228-populate-http-route-conditions
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions
Signed-off-by: Andres Llausas <[email protected]>
Signed-off-by: Andres Llausas <[email protected]>
Signed-off-by: Andres Llausas <[email protected]>
757b504
to
ec11e8e
Compare
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions Signed-off-by: Andres Llausas <[email protected]>
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions
Signed-off-by: Andres Llausas <[email protected]>
…b.com:andresllh/kserve into RHOAIENG-30228-populate-http-route-conditions
Signed-off-by: Andres Llausas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andresllh, bartoszmajsak, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0491909
into
opendatahub-io:release-v0.15
What this PR does / why we need it:
The router needs to know if the referenced http routes are ready or not to aggregate the status and mark the router as ready or not ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
KUBEBUILDER_ASSETS=$(./bin/setup-envtest use 1.33.0 -p path) go test -v --timeout 2m ./pkg/controller/llmisvc
Checklist:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.