-
Notifications
You must be signed in to change notification settings - Fork 45
chore(deps): update konflux references #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 55.87% 55.87%
=======================================
Files 9 9
Lines 2339 2339
=======================================
Hits 1307 1307
Misses 930 930
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/override ci/prow/images |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images, ci/prow/kf-notebook-controller-pr-image-mirror, ci/prow/odh-notebook-controller-e2e, ci/prow/odh-notebook-controller-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The golangci-lint failures shouldn't be relevant to this change, I created this issue #568 to track it and get rid of it eventually. /override "Code static analysis / golangci-lint (components/notebook-controller) (push)" |
@jstourac: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
It's not a failure on the PR proper, it's failure on the branch from which the PR is created... |
/ok-to-test |
/retest |
/retest kf-notebook-controller-on-pull-request |
@jstourac: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4546ff0
to
6530e19
Compare
6530e19
to
72b5774
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
72b5774
to
9b4441d
Compare
/lgtm |
/override ci/prow/images ci/prow/kf-notebook-controller-pr-image-mirror ci/prow/odh-notebook-controller-e2e |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images, ci/prow/kf-notebook-controller-pr-image-mirror, ci/prow/odh-notebook-controller-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jiridanek the fail seem to be quite consistent for the past couple of days for these konflux failed CI runs:
Are you aware of any known issue with regards to this one? I'm not sure whether the changes in this PR could be causing it - the image tasks that are updated seem to be quite irrelevant to cause this. |
Looks like the konflux failures aren't related to changes in this PR as we can see the very same failure also for the #571. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override kf-notebook-controller-on-pull-request |
@jstourac: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Red Hat Konflux / kf-notebook-controller-on-pull-request" "Red Hat Konflux / kubeflow-enterprise-contract / kf-notebook-controller" "Red Hat Konflux / kubeflow-enterprise-contract / odh-notebook-controller" "Red Hat Konflux / odh-notebook-controller-on-pull-request" |
@jstourac: Overrode contexts on behalf of jstourac: Red Hat Konflux / kf-notebook-controller-on-pull-request, Red Hat Konflux / kubeflow-enterprise-contract / kf-notebook-controller, Red Hat Konflux / kubeflow-enterprise-contract / odh-notebook-controller, Red Hat Konflux / odh-notebook-controller-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR contains the following updates:
50668ba
->00b13d0
1ed16be
->60ec0c9
32c4d3e
->cd7e802
4b704fa
->a591675
916d718
->ec2495e
To execute skipped test pipelines write comment
/ok-to-test