-
Notifications
You must be signed in to change notification settings - Fork 45
NO-JIRA: chore(.tekton/): since ubi8 (and ubi9) minimal images fail in Konflux when subscribed with entitlement certificate, hide the certificate from our build so that it does not fail #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on Slack, the suggestion was changed to an older version.
Is this a temporary change or a long-lasting one?
Reason to ask:
DevTestOps has in the past insisted on using the latest
tag.
Ref: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1715844618018909
if we do make this change here when the change is moved to the ed-hat-data-services repo,
either the dockerfile.konflux needs to update: which would conflict with what devtestops team requires
or keep the dockerfile changes separated from dockerfile.konflux , which would bring overhead to the team to maintain only this change.
It's a red herring, changing tag fixed nothing. Anyways DevOps have Dockerfile.konflux This file is odh only |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
===========================================
+ Coverage 33.15% 56.00% +22.85%
===========================================
Files 2 9 +7
Lines 941 2339 +1398
===========================================
+ Hits 312 1310 +998
- Misses 598 928 +330
- Partials 31 101 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'll use this PR for further experimantation with ubi9 and deleting secrtet |
2b64519
to
6c6386a
Compare
/retest odh-notebook-controller-on-pull-request |
This comment was marked as duplicate.
This comment was marked as duplicate.
4c6f730
to
a5e9662
Compare
/retest kf-notebook-controller-on-pull-request |
This comment was marked as off-topic.
This comment was marked as off-topic.
…n Konflux when subscribed with entitlement certificate, hide the certificate from our build so that it does not fail https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1742819729272789
e23cdcf
to
08e5cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The konflux entitlement build are failing, will there be showing up in all PRs?
/approve
That thing? It's some kind of infra issue, looks to me. Will fill support ticket if it persists tomorrow. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Opened Konflux ticket about slooow clamav-scan step https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1742920180542049 |
/lgtm |
lool |
/retest odh-notebook-controller-on-pull-request |
This comment was marked as outdated.
This comment was marked as outdated.
/retest odh-notebook-controller-on-pull-request |
@jiridanek: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/RHOAIENG-18400
Description
How Has This Been Tested?
CI
Merge criteria: