Skip to content

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 24, 2025

https://issues.redhat.com/browse/RHOAIENG-18400

Description

How Has This Been Tested?

CI

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from andyatmiami and harshad16 March 24, 2025 14:12
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 24, 2025
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Slack, the suggestion was changed to an older version.
Is this a temporary change or a long-lasting one?

Reason to ask:
DevTestOps has in the past insisted on using the latest tag.
Ref: https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1715844618018909
if we do make this change here when the change is moved to the ed-hat-data-services repo,
either the dockerfile.konflux needs to update: which would conflict with what devtestops team requires
or keep the dockerfile changes separated from dockerfile.konflux , which would bring overhead to the team to maintain only this change.

@jiridanek
Copy link
Member Author

It's a red herring, changing tag fixed nothing.

Anyways DevOps have Dockerfile.konflux

This file is odh only

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.00%. Comparing base (d99a35f) to head (4c6f730).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #572       +/-   ##
===========================================
+ Coverage   33.15%   56.00%   +22.85%     
===========================================
  Files           2        9        +7     
  Lines         941     2339     +1398     
===========================================
+ Hits          312     1310      +998     
- Misses        598      928      +330     
- Partials       31      101       +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiridanek jiridanek closed this Mar 24, 2025
@jiridanek
Copy link
Member Author

I'll use this PR for further experimantation with ubi9 and deleting secrtet

@jiridanek
Copy link
Member Author

/retest odh-notebook-controller-on-pull-request

This comment was marked as duplicate.

@jiridanek jiridanek changed the title NO-JIRA: chore(Dockerfiles): since :latest fails to build in Konflux, we should use older ubi8 [trial PR to mess with Konflux] NO-JIRA: chore(Dockerfiles): since :latest fails to build in Konflux, we should use older ubi8 Mar 25, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 25, 2025
@openshift-ci openshift-ci bot added size/s and removed size/xs labels Mar 25, 2025
@jiridanek
Copy link
Member Author

/retest kf-notebook-controller-on-pull-request

This comment was marked as off-topic.

@openshift-ci openshift-ci bot added size/xs and removed size/s labels Mar 25, 2025
…n Konflux when subscribed with entitlement certificate, hide the certificate from our build so that it does not fail

https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1742819729272789
@openshift-ci openshift-ci bot added size/s and removed size/s labels Mar 25, 2025
@jiridanek jiridanek changed the title [trial PR to mess with Konflux] NO-JIRA: chore(Dockerfiles): since :latest fails to build in Konflux, we should use older ubi8 NO-JIRA: chore(.tekton/): since ubi8 (and ubi9) minimal images fail in Konflux when subscribed with entitlement certificate, hide the certificate from our build so that it does not fail Mar 25, 2025
@openshift-ci openshift-ci bot added size/s and removed size/s labels Mar 25, 2025
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The konflux entitlement build are failing, will there be showing up in all PRs?

@jiridanek
Copy link
Member Author

/approve

Results:
✕ [Violation] builtin.image.accessible
  ImageRef: quay.io/redhat-user-workloads/rhoai-ide-konflux-tenant/kf-notebook-controller@sha256:368e2162f116486347ff9d03778c287992a0068786e857ba6e54529ac8aac4ca
  Reason: Image URL is not accessible: HEAD
  https://quay.io/v2/redhat-user-workloads/rhoai-ide-konflux-tenant/kf-notebook-controller/manifests/sha256:368e2162f116486347ff9d03778c287992a0068786e857ba6e54529ac8aac4ca:
  unexpected status code 404 Not Found (HEAD responses have no body, use GET for details)
  Title: Image URL is accessible
  Description: The image URL is available and accessible.

That thing? It's some kind of infra issue, looks to me. Will fill support ticket if it persists tomorrow.

Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

Opened Konflux ticket about slooow clamav-scan step https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1742920180542049

@daniellutz
Copy link

/lgtm

@jiridanek
Copy link
Member Author

the step "push" in TaskRun "odh-notebook-controller-on-pull-request-lf6kx-build-images-2" failed to pull the image "".
The pod errored with the message: "Back-off pulling image "quay.io/konflux-ci/buildah-task:latest@sha256:ab0ba3b70f99faa74d2dd737422a965197af4922dec0109113bc535a94db0dfd"."

lool

@jiridanek
Copy link
Member Author

/retest odh-notebook-controller-on-pull-request

This comment was marked as outdated.

@jiridanek
Copy link
Member Author

/retest odh-notebook-controller-on-pull-request

Copy link

openshift-ci bot commented Mar 25, 2025

@jiridanek: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test images
/test kf-notebook-controller-pr-image-mirror
/test kf-notebook-controller-unit
/test odh-notebook-controller-e2e
/test odh-notebook-controller-pr-image-mirror
/test odh-notebook-controller-unit

Use /test all to run the following jobs that were automatically triggered:

pull-ci-opendatahub-io-kubeflow-main-images
pull-ci-opendatahub-io-kubeflow-main-kf-notebook-controller-pr-image-mirror
pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-e2e
pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-pr-image-mirror

In response to this:

/retest odh-notebook-controller-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek merged commit c0772a3 into opendatahub-io:main Mar 25, 2025
14 of 16 checks passed
@jiridanek jiridanek deleted the jd_use_ubi-tag branch March 25, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants