Skip to content

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Apr 9, 2025

Related to: https://issues.redhat.com/browse/RHOAIENG-22918

Description

This PR updates branch references in kubeflow repo based the new release.

How Has This Been Tested?

TBD

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and jstourac April 9, 2025 08:05
@openshift-ci openshift-ci bot added the size/m label Apr 9, 2025
@jstourac
Copy link
Member

jstourac commented Apr 9, 2025

/lgtm

@atheo89
Copy link
Member Author

atheo89 commented Apr 9, 2025

Thanks for the review!
/approve

Copy link

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 9, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.42%. Comparing base (7245828) to head (e6eaf4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   55.02%   55.42%   +0.39%     
==========================================
  Files          10       10              
  Lines        2555     2555              
==========================================
+ Hits         1406     1416      +10     
+ Misses       1040     1030      -10     
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atheo89
Copy link
Member Author

atheo89 commented Apr 9, 2025

/override "Red Hat Konflux / kubeflow-enterprise-contract / pr group"

Copy link

openshift-ci bot commented Apr 9, 2025

@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / kubeflow-enterprise-contract / pr group

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/kf-notebook-controller-pr-image-mirror
  • ci/prow/kf-notebook-controller-unit
  • ci/prow/odh-notebook-controller-e2e
  • ci/prow/odh-notebook-controller-pr-image-mirror
  • ci/prow/odh-notebook-controller-unit
  • pull-ci-opendatahub-io-kubeflow-main-images
  • pull-ci-opendatahub-io-kubeflow-main-kf-notebook-controller-pr-image-mirror
  • pull-ci-opendatahub-io-kubeflow-main-kf-notebook-controller-unit
  • pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-e2e
  • pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-pr-image-mirror
  • pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / kubeflow-enterprise-contract / pr group"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89 atheo89 merged commit 07f5a24 into opendatahub-io:main Apr 9, 2025
19 of 21 checks passed
harshad16 pushed a commit to harshad16/odh-kubeflow that referenced this pull request Jul 17, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants