Skip to content

Conversation

ide-developer
Copy link
Collaborator

🤖 This is an automated Pull Request created by /.github/workflows/notebook-controller-images-updater.yaml.

Have been updated the following related files:

  • components/notebook-controller/config/overlays/openshift/params.env
  • components/odh-notebook-controller/config/base/params.env
  • components/odh-notebook-controller/makefile-vars.mk

@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 April 9, 2025 14:12
@openshift-ci openshift-ci bot added the size/xs label Apr 9, 2025
@atheo89
Copy link
Member

atheo89 commented Apr 9, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 9, 2025
@atheo89
Copy link
Member

atheo89 commented Apr 9, 2025

/override ci/prow/images

Copy link

openshift-ci bot commented Apr 9, 2025

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89 atheo89 merged commit 2830879 into v1.10-branch Apr 9, 2025
15 of 16 checks passed
@atheo89 atheo89 deleted the temp-v1.10-branch-14359206376 branch April 9, 2025 14:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (a77fe09) to head (3900006).
Report is 3 commits behind head on v1.10-branch.

Additional details and impacted files
@@               Coverage Diff                @@
##           v1.10-branch     #585      +/-   ##
================================================
+ Coverage         54.87%   55.02%   +0.15%     
================================================
  Files                10       10              
  Lines              2555     2555              
================================================
+ Hits               1402     1406       +4     
+ Misses             1043     1040       -3     
+ Partials            110      109       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants