NO-JIRA: deps({odh-}notebook-controller): update to go1.23

[jiridanek]

• NO-JIRA: chore(docs): Add guide for upgrading Go version and dependencies #574

• Release notes https://tip.golang.org/doc/go1.23

Description

This is a follow-up to

• NO-JIRA: deps({odh-}notebook-controller): update to go1.22 #571

so that we can finally get

• chore(deps): bump golang.org/x/net from 0.33.0 to 0.38.0 in /components/{odh-}notebook-controller #556

How Has This Been Tested?

GHA / OCP-CI

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jiridanek]

=== RUN   TestE2ENotebookController/update/thoth-minimal-oauth-notebook/Notebook_Statefulset_Validation_After_Update
2025/04/17 09:56:23 Failed to get thoth-minimal-oauth-notebook statefulset
    notebook_update_test.go:40: 
        	Error Trace:	/go/src/github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/e2e/notebook_update_test.go:40
        	Error:      	Received unexpected error:
        	            	error validating notebook StatefulSet: client rate limiter Wait returned an error: context deadline exceeded
        	Test:       	TestE2ENotebookController/update/thoth-minimal-oauth-notebook/Notebook_Statefulset_Validation_After_Update
        	Messages:   	error testing StatefulSet for Notebook after update 
=== RUN   TestE2ENotebookController/update/thoth-minimal-oauth-notebook/Notebook_OAuth_sidecar_Validation_After_Update
=== RUN   TestE2ENotebookController/update/thoth-minimal-oauth-notebook/Verify_Notebook_Traffic_After_Update
    notebook_update_test.go:53: 
        	Error Trace:	/go/src/github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/e2e/notebook_update_test.go:53
        	Error:      	Received unexpected error:
        	            	unexpected response from Notebook Endpoint:
        	            	HTTP/1.0 503 Service Unavailable
        	            	Connection: close
        	            	Cache-Control: private, max-age=0, no-cache, no-store
        	            	Content-Type: text/html
        	            	Pragma: no-cache
        	            	
        	Test:       	TestE2ENotebookController/update/thoth-minimal-oauth-notebook/Verify_Notebook_Traffic_After_Update
        	Messages:   	error testing Notebook traffic after update 

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_kubeflow/591/pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-e2e/1912801394373431296#1:build-log.txt%3A240

This could be a flake, or it could be manifestation of https://issues.redhat.com/browse/RHOAIENG-1576, also seen

• RHOAIENG-11155: Better explanation of 'Authorize Access' UI #449 (comment)

[jiridanek]

Let's see a rerun https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_kubeflow/591/pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-e2e/1912816318004858880

edit: which passed, so a flake

[jiridanek]

/override "Red Hat Konflux / kubeflow-enterprise-contract / pr group"

don't know what's up with this pr group thing

[openshift-ci]

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• Red Hat Konflux / kubeflow-enterprise-contract / pr group

Only the following failed contexts/checkruns were expected:

• ci/prow/images
• ci/prow/kf-notebook-controller-pr-image-mirror
• ci/prow/kf-notebook-controller-unit
• ci/prow/odh-notebook-controller-e2e
• ci/prow/odh-notebook-controller-pr-image-mirror
• ci/prow/odh-notebook-controller-unit
• pull-ci-opendatahub-io-kubeflow-main-images
• pull-ci-opendatahub-io-kubeflow-main-kf-notebook-controller-pr-image-mirror
• pull-ci-opendatahub-io-kubeflow-main-kf-notebook-controller-unit
• pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-e2e
• pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-pr-image-mirror
• pull-ci-opendatahub-io-kubeflow-main-odh-notebook-controller-unit
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / kubeflow-enterprise-contract / pr group"

don't know what's up with this pr group thing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jstourac]

/lgtm

[jiridanek]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment