Skip to content

Conversation

jiridanek
Copy link
Member

Description

This update sets the --platform flag in Docker build commands, allowing builds for specific architectures by using the ARCH variable. The default architecture is set to linux/amd64, ensuring compatibility and flexibility for multi-platform environments.

How Has This Been Tested?

❯ cd components/notebook-controller; gmake docker-build
❯ cd components/odh-notebook-controller; gmake docker-build

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…builds

This update sets the `--platform` flag in Docker build commands, allowing builds for specific architectures by using the `ARCH` variable. The default architecture is set to `linux/amd64`, ensuring compatibility and flexibility for multi-platform environments.
@openshift-ci openshift-ci bot requested review from dibryant and jstourac May 6, 2025 20:37
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/xs label May 6, 2025
@daniellutz
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 6, 2025
@jiridanek jiridanek changed the title NO-JIRA: default to building --platform=linux/amd64 images in Docker builds NO-JIRA: default to building --platform=linux/amd64 images in Docker builds May 6, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels May 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.77%. Comparing base (4ec227f) to head (6ca3011).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #596       +/-   ##
===========================================
+ Coverage   33.15%   55.77%   +22.61%     
===========================================
  Files           2       10        +8     
  Lines         941     2686     +1745     
===========================================
+ Hits          312     1498     +1186     
- Misses        598     1071      +473     
- Partials       31      117       +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atheo89
Copy link
Member

atheo89 commented May 7, 2025

Cool! Thanks Jiri!
/lgtm

@jiridanek jiridanek merged commit 72ac948 into opendatahub-io:main May 7, 2025
17 of 21 checks passed
@jiridanek jiridanek deleted the jd_sec_updates branch May 7, 2025 08:42
jstourac pushed a commit to jstourac/kubeflow that referenced this pull request Aug 27, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants