Skip to content

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration removal

Copy link

openshift-ci bot commented May 9, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from andyatmiami and caponetto May 9, 2025 07:02
Copy link

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/xxl label May 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (72ac948) to head (82f088a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   56.77%   56.47%   -0.30%     
==========================================
  Files          10       10              
  Lines        2686     2686              
==========================================
- Hits         1525     1517       -8     
- Misses       1039     1045       +6     
- Partials      122      124       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jstourac
Copy link
Member

jstourac commented May 12, 2025

Why? With this we won't have the images build for the main branch that is used in the ODH effectively. Is this some kind of a restriction that need to be followed among all the components around here?

Update: I see that the #599 was closed by @MohammadiIram - maybe this should be closed without merge too?

@harshad16
Copy link
Member

@harshad16 harshad16 closed this Jun 3, 2025
@harshad16 harshad16 deleted the konflux-purge-odh-notebook-controller branch August 25, 2025 16:06
jstourac pushed a commit to jstourac/kubeflow that referenced this pull request Aug 27, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants