-
Notifications
You must be signed in to change notification settings - Fork 44
add @Hannah-Tosi to OWNERS #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe update modifies the Changes
Sequence Diagram(s)No sequence diagram is generated as the change only affects repository ownership metadata. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
OWNERS (2)
5-5
: Canonicalise the GitHub handle & keep the list alphabetically sorted
Hannah-Tosi
is capitalised, whereas every other handle in the list is lowercase. OWNERS parsing is case-insensitive, but mixed-case can trip automated tooling and breaks the obvious alphabetical ordering (it should sort betweencaponetto
andharshad16
ashannah-tosi
).- - Hannah-Tosi + - hannah-tosi # keep handles lowercase & list alphabeticallyPlease double-check the exact GitHub username spelling before committing.
16-16
: Mirror the lowercase change in the reviewers sectionFor consistency with the approvers list and other existing entries, use the same lowercase handle here:
- - Hannah-Tosi + - hannah-tosi
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
OWNERS
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build
- GitHub Check: build
- GitHub Check: build
- GitHub Check: build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
- Coverage 57.37% 57.04% -0.33%
==========================================
Files 11 11
Lines 3071 3071
==========================================
- Hits 1762 1752 -10
- Misses 1138 1157 +19
+ Partials 171 162 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/verify-owners |
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing
|
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit