[pull] master from kubeflow:master #670
Open
+205,866
−317,147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Add tab to show the full yaml of the PVC. Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
* twa(front): Update @angular/common package Signed-off-by: Elena Zioga <[email protected]> * twa(front): Fix unit tests Signed-off-by: Elena Zioga <[email protected]> * gh-actions: Add GH action to run TWA unit tests Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* jwa(front): Add source maps in the browser * Enable source maps in both development and production. Signed-off-by: Elena Zioga <[email protected]> * vwa(front): Add source maps in the browser * Enable source maps in both development and production. Signed-off-by: Elena Zioga <[email protected]> * twa(front): Add source maps in the browser * Enable source maps in both development and production. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* Introduce github action workflow for intergration test Signed-off-by: Apostolos Gerakaris <[email protected]> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <[email protected]> * Remove kind & manifest gh action tests * Review fixes Signed-off-by: Apostolos Gerakaris <[email protected]> * Extend intergration test * Trigger workflow when kfam code changes since KFAM manifests are deployed with Profile Controller manifests. * Build KFAM image as well and update manifests with sed before deploying them in the KinD cluster. * Update tag in manifests to v1.6.0 since the images with tag v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
* jwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* twa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* vwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <[email protected]>
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Introduce intergration test workflow for tensorboard-controller Signed-off-by: Apostolos Gerakaris <[email protected]> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <[email protected]> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <[email protected]> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
* Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <[email protected]> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <[email protected]> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <[email protected]> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
Extend spinner component by adding some text below the spinner in order to inform users why we're spinning about. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
* Fix centrardashboard-angular docker-build workflow
Signed-off-by: Apostolos Gerakaris <[email protected]>
Signed-off-by: Apostolos Gerakaris <[email protected]>
* poddefaults: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Introduce bash script to install cert-manager
Signed-off-by: Apostolos Gerakaris <[email protected]>
* review: Fix cert-manager installation script
Signed-off-by: Apostolos Gerakaris <[email protected]>
Signed-off-by: Apostolos Gerakaris <[email protected]>
* jwa(front): Fix panel.ts file Signed-off-by: Elena Zioga <[email protected]> * jwa(front): Modify form name component Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Add a helper tooltip in section component Signed-off-by: Elena Zioga <[email protected]> * jwa(front): Rework the Create page Signed-off-by: Elena Zioga <[email protected]> * jwa(front): Fix linting errors Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* Fix docker-publish workflows * Remove workflow that builds/push all images * Remove redundant files from manifests
* vwa(front): Handle query parameters in Volume details page Add query parameter handling for each tab in order for the user to be able to navigate directly to the tab of choice inside the Volume details page. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Add unit tests for volume-details-page component Add unit tests in order to: - Show only the proper tab according to query parameters passed. - Switch tabs according to query parameters passed. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Add unit tests for overview component Signed-off-by: Orfeas Kourkakis <[email protected]> * gh-actions(vwa): Add frontend tests Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Fix linting errors Signed-off-by: Orfeas Kourkakis <[email protected]>
* jwa(front): Add buttons to Notebook details page In this commit: - Add buttons for Connect, Start/Stop, Delete actions. - Create Actions Service to handle button actions and implement it in all components that use these buttons. - Small CSS tweak in title toolbar component in order for buttons to be aligned horizontally. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Handle query parameters in Notebook page Add query parameter handling for each tab in order for the user to be able to navigate directly to the tab of choice inside the Notebook details page. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Add default values in lib-conditions-table fields Add default values for lastTransitionTime, reason & message fields in order to prevent the table's Sorting functionality returning error due to null values. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Add unit tests for notebook-page component In this commit, add unit tests in order to: - Show only the proper tab according to query parameters passed. - Switch tabs according to query parameters passed. - Update disabled field of buttons according to notebook status. - Update start/stop button according to notebook status. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Add unit tests for OVERVIEW tab component Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
* jwa(front): Add formatting/linting to JWA's frontend workflow Signed-off-by: Elena Zioga <[email protected]> * Update .github/workflows/jwa_frontend_tests.yaml Co-authored-by: Kimonas Sotirchos <[email protected]> * Update .github/workflows/jwa_frontend_tests.yaml Co-authored-by: Kimonas Sotirchos <[email protected]> Signed-off-by: Elena Zioga <[email protected]> Co-authored-by: Kimonas Sotirchos <[email protected]>
…6848) * Introduce manifests for centraldb-angular component The manifests are identical to the ones we have for the centraldashboard component. Changes: * Fix image/name references to be centraldashboard-angular Signed-off-by: Apostolos Gerakaris <[email protected]> * centraldb-angular: Extend tests for using images of each PR Changes: * Introduce intergration test workflow * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
) * Extend docker publish workflows to be triggered on Version change Changes: * Add the path releasing/version/VERSION in the paths * Use the 'dorny/paths-filter@v2' action to monitor the path "releasing/version/VERSION" and if it changes run a step that pushes the image with the TAG=$(cat releasing/version/VERSION) * Set fetch-depth:0 to fetch all history for all tags and branches. This is required so that the tags won't end up being just a hash commit. Signed-off-by: Apostolos Gerakaris <[email protected]> * Set Version to `latest` Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
…6854) Signed-off-by: Apostolos Gerakaris <[email protected]> review changes * build images with the latest tag only when a PR is merged to master branch * revert changes in manifests/workflows for the notebook-server images Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to show the namespace selector, they only checked if there is no env.production variable available. This resulted in the selector not showing even if there was no dashboard which is not expected. Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
* web-apps(front): Create lib-urls component Create a URLs component in Kubeflow common library which takes a list of URLs and their corresponding name and exposes them horizontally in a div. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Add unit test for lib-urls Add a unit test for lib-urls component Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Remove column Volumes from index page Remove Volumes column from the table in JWA's index page. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Link to a Volume details from JWA details page - Expose all volumes from a notebook, not only PVCs. - Expose the volumes grouped by type, having PVCs link to their corresponding volume details page in VWA, using lib-urls component. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Implement lib-urls in VWA details page Implement lib-urls component in the OVERVIEW tab of VWA's volume details page to avoid duplicate code. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Use common link styles Use common link styles in configurations component. Signed-off-by: Orfeas Kourkakis <[email protected]> * Fix linting errors Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
* web-apps(front): Sort tables according to input Configure tableConfig with new fields (column and order) that the table will use to sort items during initialization. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Sort conditions table by timestamp Initialize conditions table sorted by Last Transition Time column, with the most recent ones being on top. Signed-off-by: Orfeas Kourkakis <[email protected]> * jwa(front): Sort events by timestamp Initialize events table in EVENTS tab by Created at column, with the most recent ones being on top. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Sort events by timestamp Initialize events table in EVENTS tab by Created at column, with the most recent ones being on top. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Fix format errors Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
…ges (#6860) * Set REGISTRY prefix when building notebook-server images Signed-off-by: Apostolos Gerakaris <[email protected]> * Fix publish workflows for nb-server images when a PR is merged Whenever a PR is merged: * Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty) * Build/Push notebook-server images with TAG=latest when the target branch is master * Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when Version changes Signed-off-by: Apostolos Gerakaris <[email protected]> * Update manifests to use latest tag for notebook-server images Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
…lows (#6863) Revert changes introduced in #6849 regarding fetching all history for all tags and branches when workflows run. Signed-off-by: Apostolos Gerakaris <[email protected]> Signed-off-by: Apostolos Gerakaris <[email protected]>
…#6846) * centraldashboard-angular(front): Add source maps in the browser Enable source maps in both development and production. Signed-off-by: Orfeas Kourkakis <[email protected]> * centraldashboard-angular(front): Add library.js file Copy libary.js file from the old centraldashboard project and build it using webpack. Signed-off-by: Orfeas Kourkakis <[email protected]> * centraldashboard(front): Configure ESLint Signed-off-by: Orfeas Kourkakis <[email protected]> * fixup! centraldashboard-angular(front): Add library.js file Signed-off-by: Orfeas Kourkakis <[email protected]>
* vwa(front): Format code Signed-off-by: Elena Zioga <[email protected]> * vwa(front): Add formatting/linting to VWA's frontend workflow Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* web-apps(front): Add script Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Install Prettier Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Format code Signed-off-by: Elena Zioga <[email protected]> * web-apps(front): Create a workflow for code formatting/linting and unit tests Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* web-apps(front): Remove Protractor files Remove Protractor files since it's not used anywhere in the common code. Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Add Cypress attributes Add more attributes and modify some existing ones for elements to be selectable during UI tests with Cypress. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Install Cypress - Install Cypress & npm scripts for UI tests - Remove Protractor files - Update README.md with UI tests instructions Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Add UI tests with Cypress - Add Cypress attributes for elements to be selectable during UI tests. - Add UI tests with Cypress to check that: * New Volume form dialog has proper values * Index page table contains all PVC names received * Index page table status icons are correctly shown * Index page table browse buttons are correctly shown Signed-off-by: Orfeas Kourkakis <[email protected]> * gh-actions(vwa): Add UI tests to VWA's frontend workflow Add UI tests to VWA's frontend workflow. These tests should run in Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox installations by default. Signed-off-by: Orfeas Kourkakis <[email protected]> * vwa(front): Fix formatting errors Signed-off-by: Orfeas Kourkakis <[email protected]> * web-apps(front): Fix format errors Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
* twa(front): Add script file Signed-off-by: Elena Zioga <[email protected]> * twa(front): Install Prettier Signed-off-by: Elena Zioga <[email protected]> * twa(front): Format code Signed-off-by: Elena Zioga <[email protected]> * twa(front): Add formatting/linting to TWA's frontend workflow Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
…#6855) * centraldashboard(front): Add script file Signed-off-by: Elena Zioga <[email protected]> * centraldashboard(front): Move linting check to app's frontend workflow Signed-off-by: Elena Zioga <[email protected]> * gh-actions: Remove frontend_linting workflow Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
In this commit we extend workflow for running frontend tests. For the CentralDashboard (Angular) tests we also need to ensure some underlying apps are proxied. In this commit we extended the dedicated workflow for the frontend tests by: 1. Applying the necessary KF Controllers (Profiles, Notebooks) 2. Applying the JWA manifests and port-forward its k8s Service 3. Applying the VWA manifests and port-forward its k8s Service 4. Creating a user namespace (kubeflow-user) via a Profile 5. Creating a test Notebook, with a PVC, in that namespace Next steps will be to run the Cypress tests of the CDB (Angular) that will be using the proxied apps. Signed-off-by: Kimonas Sotirchos <[email protected]> Signed-off-by: Kimonas Sotirchos <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
* ci: downgrade qemu, fix arm64 build segfaults Signed-off-by: Mathew Wicks <[email protected]> * noop change to trigger notebook images to build Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
* chore: migrate docker images to ghcr Signed-off-by: Eder Ignatowicz <[email protected]> * adding dash for central dashboard Signed-off-by: Eder Ignatowicz <[email protected]> * update the spawner images Signed-off-by: Eder Ignatowicz <[email protected]> * try to fix qemu Signed-off-by: Eder Ignatowicz <[email protected]> * fix notebook-servers GHCR image path Signed-off-by: Mathew Wicks <[email protected]> * update example-notebook-servers README Signed-off-by: Mathew Wicks <[email protected]> * fix missed `IMG` updates Signed-off-by: Mathew Wicks <[email protected]> * remove remaining cases of `kubeflownotebookswg` Signed-off-by: Mathew Wicks <[email protected]> * fix typos Signed-off-by: Mathew Wicks <[email protected]> * remove `DOCKER_USER` env-var from workflows Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
…#7697) Signed-off-by: Justin Bronn <[email protected]>
Signed-off-by: Tobias Goerke <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Yuichiro Utsumi <[email protected]>
* Update Kubeflow Description Signed-off-by: Andrey Velichkevich <[email protected]> * Address feedback Signed-off-by: Andrey Velichkevich <[email protected]> * Remove capital letters Signed-off-by: Andrey Velichkevich <[email protected]> * Update description Signed-off-by: Andrey Velichkevich <[email protected]> * Remove open source Signed-off-by: Andrey Velichkevich <[email protected]> * Fix text and title Signed-off-by: Andrey Velichkevich <[email protected]> --------- Signed-off-by: Andrey Velichkevich <[email protected]>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )