fix: use correct DNS for evalhub#134
Conversation
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
📝 WalkthroughWalkthroughChanges to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@main.py`:
- Around line 381-388: The update currently writes new OCI annotation keys via
coords.annotations.update; to remain backward-compatible also write the legacy
org.evalhub.* keys alongside the new io.github.eval-hub.* and
org.opencontainers.image.created keys so consumers reading the old namespace
still see metadata. Modify the coords.annotations.update payload to include
duplicate legacy keys (e.g., "org.evalhub.image.created" or matching legacy
names for created/benchmark/model/job_id) set to the same values
(datetime.now(UTC).isoformat(), benchmark_id, model_name, job_id) so both
namespaces are written during migration; remove the legacy keys in a future,
explicitly versioned change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 22c55c55-907e-433e-bb00-a34c9d7be680
📒 Files selected for processing (1)
main.py
| coords.annotations.update( | ||
| { | ||
| "org.opencontainers.image.created": datetime.now(UTC).isoformat(), | ||
| "org.evalhub.benchmark": benchmark_id, | ||
| "org.evalhub.model": model_name, | ||
| "org.evalhub.job_id": job_id, | ||
| "io.github.eval-hub.benchmark": benchmark_id, | ||
| "io.github.eval-hub.model": model_name, | ||
| "io.github.eval-hub.job_id": job_id, | ||
| } | ||
| ) |
There was a problem hiding this comment.
Add backward-compatible annotation keys to avoid metadata contract break
This change silently renames externally consumed OCI annotation keys. If any consumer still reads org.evalhub.*, artifact processing can fail (integration reliability break). Write both namespaces during migration, then remove legacy keys in a later versioned change.
Proposed compatibility patch
coords.annotations.update(
{
"org.opencontainers.image.created": datetime.now(UTC).isoformat(),
+ # Legacy namespace (backward compatibility)
+ "org.evalhub.benchmark": benchmark_id,
+ "org.evalhub.model": model_name,
+ "org.evalhub.job_id": job_id,
+ # New reverse-DNS namespace
"io.github.eval-hub.benchmark": benchmark_id,
"io.github.eval-hub.model": model_name,
"io.github.eval-hub.job_id": job_id,
}
)As per coding guidelines, "REVIEW PRIORITIES: 2. Architectural issues and anti-patterns; 3. Bug-prone patterns and error handling gaps."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@main.py` around lines 381 - 388, The update currently writes new OCI
annotation keys via coords.annotations.update; to remain backward-compatible
also write the legacy org.evalhub.* keys alongside the new io.github.eval-hub.*
and org.opencontainers.image.created keys so consumers reading the old namespace
still see metadata. Modify the coords.annotations.update payload to include
duplicate legacy keys (e.g., "org.evalhub.image.created" or matching legacy
names for created/benchmark/model/job_id) set to the same values
(datetime.now(UTC).isoformat(), benchmark_id, model_name, job_id) so both
namespaces are written during migration; remove the legacy keys in a future,
explicitly versioned change.
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Description
small fix reverse DNS
How Has This Been Tested?
not needed
Merge criteria:
Summary by CodeRabbit