sync: main to stable#1172
Conversation
…2093) Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
…eview state handling (kubeflow#2034) * Preview pagination fixes: initial Claude attempt Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Update BFF mocks Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Fix summary text Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Fix empty state text Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Fix bff errors Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Add tests Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Fix bug with not properly switching back to included tab when running a fresh preview Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Full reset preview state on fresh preview Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Rename isLoading to isLoadingInitial Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Use an enum for PreviewTab Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Factor out useSourcePreview hook and add tests for it Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Clean up props derived from the new hook Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Add more mock data to test pagination of previews in mock mode Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * Address PR review feedback for preview pagination - Add PreviewMode enum for 'preview' | 'validate' type safety - Extract DEFAULT_PREVIEW_PAGE_SIZE constant for magic number - Replace JSON.stringify with lodash isEqual for deep comparison - Extract getTargetTab helper function for improved readability - Update tests to use enum values Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> --------- Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Add compression level comparison card to details page Signed-off-by: ppadti <ppadti@redhat.com> * Fix test and corner case Signed-off-by: ppadti <ppadti@redhat.com> * Add unit test, fix ux issues Signed-off-by: ppadti <ppadti@redhat.com> * Fix test Signed-off-by: ppadti <ppadti@redhat.com> --------- Signed-off-by: ppadti <ppadti@redhat.com>
…clients/python (kubeflow#2098) Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.35.4 to 20.36.1. - [Release notes](https://github.com/pypa/virtualenv/releases) - [Changelog](https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst) - [Commits](pypa/virtualenv@20.35.4...20.36.1) --- updated-dependencies: - dependency-name: virtualenv dependency-version: 20.36.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kubeflow#2099) * build(deps): bump filelock from 3.20.1 to 3.20.3 in /jobs/async-upload Bumps [filelock](https://github.com/tox-dev/py-filelock) from 3.20.1 to 3.20.3. - [Release notes](https://github.com/tox-dev/py-filelock/releases) - [Changelog](https://github.com/tox-dev/filelock/blob/main/docs/changelog.rst) - [Commits](tox-dev/filelock@3.20.1...3.20.3) --- updated-dependencies: - dependency-name: filelock dependency-version: 3.20.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * align requirements.txt Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
…nts/python (kubeflow#2100) Bumps [filelock](https://github.com/tox-dev/py-filelock) from 3.20.1 to 3.20.3. - [Release notes](https://github.com/tox-dev/py-filelock/releases) - [Changelog](https://github.com/tox-dev/filelock/blob/main/docs/changelog.rst) - [Commits](tox-dev/filelock@3.20.1...3.20.3) --- updated-dependencies: - dependency-name: filelock dependency-version: 3.20.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[pull] main from kubeflow:main
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: github-actions[bot], jonburdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sync-branches: New code has just landed in main, so let's bring stable up to speed!