sync: main to stable#1643
Conversation
The optional email field in the OCI destination credentials section is unnecessary — OCI registry auth works fine without it and users are not typically asked for it. Removes the email field from: - Frontend form, types, state, and payload builder - BFF Go destination struct and docker config generation - OpenAPI spec - Test mocks and test data Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…low#2312) * Fix broken link fro create version intent,missing display name and other bugs Signed-off-by: ppadti <ppadti@redhat.com> * Fix cypress tests Signed-off-by: ppadti <ppadti@redhat.com> * Update readme and openapi spec Signed-off-by: ppadti <ppadti@redhat.com> * Use the correct namespace for cleanup Signed-off-by: ppadti <ppadti@redhat.com> * Update readme and create util fro jobNamespace Signed-off-by: ppadti <ppadti@redhat.com> --------- Signed-off-by: ppadti <ppadti@redhat.com>
* add mcp catalog Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * add tests Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * use the mcp objects Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * extract type and fix other comments Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * move test to the right directory Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * fix filters, PR comments and hooks Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * fix PR comments and changes request Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * add last changes requested in the PR Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * fix hook cards categories Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> * adding changes requested Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com> --------- Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
…ubeflow#2360) * Remove duplicate jobNamespace Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> * Address tech-debt from kubeflow#2312 Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> --------- Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
…3 in /clients/ui/bff (kubeflow#2351) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.22.4 to 0.23.3. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.3) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
…nd make namespace dropdown scrollable (kubeflow#2326) * fix: show all user-accessible namespaces in register-and-store form The NamespaceSelectorField was reusing the global NamespaceSelector component which gets its namespace list from mod-arch-core's context. When MANDATORY_NAMESPACE is set (e.g. in RHOAI), the context only returns that one namespace, preventing users from selecting other namespaces for their model transfer jobs. Replace the shared NamespaceSelector in the form with a direct SimpleSelect using the local useNamespaces() hook, which calls the BFF endpoint directly and returns all namespaces the user has access to. Rename the original component to GlobalNamespaceSelector to clarify its role as the NavBar-only global selector. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * fix: surface namespace fetch loading/error states in NamespaceSelectorField Destructure loaded and error from useNamespaces() and display appropriate feedback: a loading message while fetching, a danger alert if the fetch fails, and only show the "no access" warning when namespaces have loaded successfully but the list is empty. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * test: add Cypress tests for namespace selector error states Add tests for namespace fetch error (500 from GET /namespaces) and namespace access check error (500 from POST /check-namespace-registry-access), covering error alerts, disabled selector, hidden form sections, and disabled submit button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * fix: add scrollable constraint to namespace selector dropdowns Namespace dropdowns with many items could overflow the page container, causing broken scroll behavior. Add isScrollable and maxMenuHeight="300px" to both the form namespace selector and the navbar namespace selector, using PatternFly's built-in Select props. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> * fix(test): use dynamic handler for namespace loading error test The namespace error intercept was catching the initial namespace fetch from the app context/navbar, preventing the page from rendering. Use a dynamic handler that lets the first call succeed and only fails subsequent calls from the form's useNamespaces hook. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> --------- Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#2349) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.4 to 0.35.2. - [Commits](kubernetes/apimachinery@v0.34.4...v0.35.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…beflow#2340) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.34.2 to 0.35.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.34.2...0.35.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v3...v4) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3...v4) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v3...v4) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* prepend source id to model name in catalog db Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * update test Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * update on save Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * pytest updates for new source keys Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * pytest Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * revert and update pagination Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * remove migrations Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> * trailing line Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com> --------- Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6 to 7. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6...v7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* details page+readme Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * lint Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * Fix contract test: resolve OpenAPI spec gaps and align test fixtures (kubeflow#2360) * Remove duplicate jobNamespace Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> * Address tech-debt from kubeflow#2312 Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> --------- Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * build(deps): bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.3 in /clients/ui/bff (kubeflow#2351) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.22.4 to 0.23.3. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.3) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * addressed comments Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * comments latests Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> --------- Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Manaswini Das <dasmanaswini10@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[pull] main from kubeflow:main
|
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dbasunag, github-actions[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sync-branches: New code has just landed in main, so let's bring stable up to speed!