[RHOAIENG-22052] Updated test suites that were previously failing #333
Merged
openshift-merge-bot[bot] merged 6 commits intoopendatahub-io:mainfrom May 28, 2025
Merged
Conversation
mholder6
force-pushed
the
updating-tests
branch
from
de0eb4f to
9c9b5c3
Compare
mholder6
force-pushed
the
updating-tests
branch
from
9c9b5c3 to
b5e1322
Compare
mholder6
changed the title
mholder6
force-pushed
the
updating-tests
branch
2 times, most recently
from
6fa6d32 to
615108d
Compare
Signed-off-by: Mariah Holder <marholde@redhat.com>
Signed-off-by: Mariah Holder <marholde@redhat.com>
Signed-off-by: Mariah Holder <marholde@redhat.com> Tracking progress Signed-off-by: Mariah Holder <marholde@redhat.com>
… hpa tests are ran Signed-off-by: Mariah Holder <marholde@redhat.com>
Member
|
/retest |
spolti
reviewed
May 15, 2025
Signed-off-by: Mariah Holder <marholde@redhat.com>
Signed-off-by: Mariah Holder <94134625+mholder6@users.noreply.github.com>
spolti
reviewed
May 16, 2025
| containers: | ||
| - name: "copy-pod" | ||
| image: quay.io/jooholee/modelmesh-minio-examples:latest | ||
| image: quay.io/rh-ee-allausas/modelmesh-minio-examples:latest |
Member
There was a problem hiding this comment.
Can we have an image under opendatahub org instead? wdyt?
spolti
reviewed
May 16, 2025
|
|
||
| # info "installing namespaced rbac" | ||
| kustomize build "${archive_folder}"/config/rbac/namespace-scope | oc apply -n "${ctrlnamespace}" -f - | ||
| kustomize build "${archive_folder}"/config/rbac/namespace-scope | oc apply -n modelmesh-serving f - |
Member
There was a problem hiding this comment.
this should be the controller namespace, did you find issues using the env?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mholder6, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spolti
added a commit
to spolti/modelmesh-serving
that referenced
this pull request
May 16, 2025
…release Sync/250408 odh release
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Get the e2e tests working for the modelmesh-serving component
Modifications
Updated and added logic to any tests that were failing
How to Test
CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving NAMESPACESCOPEMODE=true make e2e-test-for-odhYou should see the following output (or something similar since I previously had everything installed) for the first few lines:
./opendatahub/scripts/install_odh.sh --ctrl-namespace opendatahub .. Downloading binaries yq already installed. kustomize already installed with correct version... Delete the exising /tmp/modelmesh-e2e folder Creating a /tmp/modelmesh-e2e folder Now using project "opendatahub" on server "https://api.l5a1t7e9q9f7d2q.de90.p3.openshiftapps.com:443". subscription.operators.coreos.com/opendatahub-operator unchanged .. Opendatahub operator is ready .. Creating the DSC in opendatahub dscinitialization.dscinitialization.opendatahub.io/default-dsci unchanged datasciencecluster.datasciencecluster.opendatahub.io/default-dsc unchanged All -l control-plane=modelmesh-controller pods in 'opendatahub' namespace are running and ready. [SUCCESS] ModelMesh is RunningAfter the set up is complete the suite tests will run. It will take about 15~20 minutes total. The first time it is ran it may take longer due to having to install the required images for the tests.
Warning
Some of the tests will face timeout issues occasionally, and will fail. But the test suite will rerun and it should pass the next time. It maxes out at 4 reruns.
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags