Skip to content

Updated utils script for kustomize error#357

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:mainfrom
mholder6:updating-tests
Jun 24, 2025
Merged

Updated utils script for kustomize error#357
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:mainfrom
mholder6:updating-tests

Conversation

@mholder6
Copy link

@mholder6 mholder6 commented Jun 24, 2025

updated the utils script to extract the kustomize version accurately

Motivation

fix the failing rehearsal test - getting the following error when trying to install kustomize due to the CI outputting multiple arguments when running kustomize version. Error below:

./opendatahub/scripts/utils.sh: line 264: [: too many arguments

@red-hat-konflux
Copy link

red-hat-konflux bot commented Jun 24, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
template no kind "TriggerTemplate" is registered for version "tekton.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
binding no kind "TriggerBinding" is registered for version "tekton.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
listener no kind "EventListener" is registered for version "tekton.dev/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mholder6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Jun 24, 2025

Walkthrough

The install_binaries function in the opendatahub/scripts/utils.sh script was updated to accurately extract and compare the semantic version number of the kustomize binary. The new approach uses pattern matching to isolate the version, ensuring robust version checks regardless of additional output text.

Changes

File Change Summary
opendatahub/scripts/utils.sh Improved version extraction and comparison logic in install_binaries for the kustomize binary.

Poem

A script in the burrow, so clever and neat,
Now checks its versions before it repeats.
With grep and a hop, it finds what it needs,
Ensuring the right kustomize for all of our deeds.
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Mariah Holder <marholde@redhat.com>
@mholder6 mholder6 changed the title Updating tests Updated utils script for kustomize error Jun 24, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e4afed and 2eeba8e.

📒 Files selected for processing (1)
  • opendatahub/scripts/utils.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (go)

@VedantMahabaleshwarkar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c25e59a into opendatahub-io:main Jun 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants