-
Notifications
You must be signed in to change notification settings - Fork 105
Optimize and Enable Runtime Datascience Images for IBM Z[s390x] (Python 3.11 & 3.12) #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nash-123
wants to merge
3
commits into
opendatahub-io:main
Choose a base branch
from
Nash-123:runtime-datascience-s390x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+520
−278
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 41 additions & 41 deletions
82
jupyter/pytorch+llmcompressor/ubi9-python-3.11/Pipfile.lock
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
safetensors 0.6.2: confirm s390x wheel availability or gate for s390x
If this image is ever built for s390x, safetensors may require Rust if wheels aren’t available. Consider gating on s390x to avoid unexpected source builds, or plan a Rust toolchain stage.
Would you verify s390x wheel availability for safetensors 0.6.2?
If gating is desired, adjust the marker:
🌐 Web query:
💡 Result:
As of August 8, 2025, the PyPI wheels for
safetensors
version 0.6.2 do not include a pre-built wheel for thelinux s390x
architecture with Python 3.11. The available wheels for this version are:cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
cp311-cp311-manylinux_2_17_armv7l.manylinux2014_armv7l.whl
cp311-cp311-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl
cp311-cp311-manylinux_2_17_i686.manylinux1_i686.whl
cp311-cp311-macosx_11_0_arm64.whl
cp311-cp311-macosx_10_12_x86_64.whl
These wheels are compatible with various architectures, including x86_64, aarch64, armv7l, ppc64le, i686, and macOS platforms.
For the
linux s390x
architecture, the most recent available wheel is forsafetensors
version 0.5.3, which includes:cp38-abi3-manylinux_2_17_s390x.manylinux2014_s390x.whl
This wheel is compatible with Python 3.8. (pypi.org)
Given the absence of a pre-built wheel for
safetensors
0.6.2 onlinux s390x
with Python 3.11, you may need to build the package from source. Ensure that you have the necessary build tools and dependencies installed. Detailed instructions for buildingsafetensors
from source can be found in the project's documentation.Citations:
safetensors 0.6.2 lacks linux/s390x wheel—gate or add Rust toolchain
safetensors 0.6.2 publishes wheels for x86_64, aarch64, armv7l, ppc64le, i686 and macOS, but no Python 3.11 manylinux wheel for s390x. On s390x this will fall back to source build (requiring Rust). To prevent unexpected Rust builds, either gate out s390x installs or ensure a Rust/Cargo stage is present.
Locations to address:
Suggested gating diff:
Alternatively, update your s390x image builds to install the Rust toolchain before pip.
📝 Committable suggestion
🤖 Prompt for AI Agents