Skip to content

Update test_jupyter_with_papermill.sh script for python312 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

Update test_jupyter_with_papermill.sh script for python312 #1518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06b5e69
Update test_jupyter_with_papermill.sh with Andys help
hmtosi Jul 25, 2025
c9dda5c
remove extra dash from filename string
hmtosi Jul 25, 2025
2d8b9c1
Merge branch 'opendatahub-io:main' into update_test_script_for_python312
hmtosi Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions scripts/test_jupyter_with_papermill.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,28 +185,42 @@ function _get_source_of_truth_filepath()
local notebook_id="${1##*/}"

local manifest_directory="${root_repo_directory}/manifests"
local imagestream_directory="${manifest_directory}/base"

local file_suffix='notebook-imagestream.yaml'
local imagestream_directory=
local file_suffix=
local filename=
case "${notebook_id}" in
*$jupyter_minimal_notebook_id*)
filename="jupyter-${accelerator_flavor:+"$accelerator_flavor"-}${notebook_id}-${file_suffix}"
if [ "${accelerator_flavor}" = 'cuda' ]; then
filename="jupyter-${notebook_id}-gpu-${file_suffix}"
fi
;;
*$jupyter_datascience_notebook_id* | *$jupyter_trustyai_notebook_id*)
filename="jupyter-${notebook_id}-${file_suffix}"
case "${python_flavor}" in
python-3.12)
imagestream_directory="${manifest_directory}/overlays/additional"
file_suffix='imagestream.yaml'

local imagestream_accelerator_flavor="${accelerator_flavor:-cpu}"
filename="jupyter-${notebook_id}-${imagestream_accelerator_flavor}-py312-${os_flavor}-${file_suffix}"
;;
*$jupyter_pytorch_notebook_id* | *$jupyter_tensorflow_notebook_id*)
filename="jupyter-${accelerator_flavor:+"$accelerator_flavor"-}${notebook_id}-${file_suffix}"
if [ "${accelerator_flavor}" = 'cuda' ]; then
filename="jupyter-${notebook_id}-${file_suffix}"
fi
*)
imagestream_directory="${manifest_directory}/base"
file_suffix='notebook-imagestream.yaml'

case "${notebook_id}" in
*$jupyter_minimal_notebook_id*)
filename="jupyter-${accelerator_flavor:+"$accelerator_flavor"-}${notebook_id}-${file_suffix}"
if [ "${accelerator_flavor}" = 'cuda' ]; then
filename="jupyter-${notebook_id}-gpu-${file_suffix}"
fi
;;
*$jupyter_datascience_notebook_id* | *$jupyter_trustyai_notebook_id*)
filename="jupyter-${notebook_id}-${file_suffix}"
;;
*$jupyter_pytorch_notebook_id* | *$jupyter_tensorflow_notebook_id*)
filename="jupyter-${accelerator_flavor:+"$accelerator_flavor"-}${notebook_id}-${file_suffix}"
if [ "${accelerator_flavor}" = 'cuda' ]; then
filename="jupyter-${notebook_id}-${file_suffix}"
fi
;;
esac
;;
esac


local filepath="${imagestream_directory}/${filename}"

if ! [ -e "${filepath}" ]; then
Expand Down Expand Up @@ -381,7 +395,7 @@ jupyter_pytorch_notebook_id='pytorch'
jupyter_tensorflow_notebook_id='tensorflow'

notebook_name=$( _get_notebook_name "${test_target}" )
python_flavor="python-${test_target//*-python-/}"
python_flavor="python-${test_target//*-python-/}" # <-- python-3.11
os_flavor=$(_get_os_flavor "${test_target}")
accelerator_flavor=$(_get_accelerator_flavor "${test_target}")

Expand Down
Loading