-
Notifications
You must be signed in to change notification settings - Fork 107
RHAIENG-540: build(deps): bump transformers from 4.52.4 to 4.53.0 in /jupyter/trustyai/ubi9-python-3.11 and to 4.55.0 in the 3.12 version of workbench #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
64186ad
531d713
d4400d5
e3909ac
19686aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2999,9 +2999,9 @@ tqdm==4.67.1; python_version >= '3.7' \ | |
traitlets==5.14.3; python_version >= '3.8' \ | ||
--hash=sha256:9ed0579d3502c94b4b3732ac120375cda96f923114522847de4b3bb98b96b6b7 \ | ||
--hash=sha256:b74e89e397b1ed28cc831db7aea759ba6640cb3de13090ca145426688ff1ac4f | ||
transformers==4.52.4; python_full_version >= '3.9.0' \ | ||
--hash=sha256:203f5c19416d5877e36e88633943761719538a25d9775977a24fe77a1e5adfc7 \ | ||
--hash=sha256:aff3764441c1adc192a08dba49740d3cbbcb72d850586075aed6bd89b98203e6 | ||
transformers==4.53.3; python_full_version >= '3.9.0' \ | ||
--hash=sha256:5aba81c92095806b6baf12df35d756cf23b66c356975fb2a7fa9e536138d7c75 \ | ||
--hash=sha256:b2eda1a261de79b78b97f7888fe2005fc0c3fabf5dad33d52cc02983f9f675d8 | ||
Comment on lines
+3002
to
+3004
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainVerify hashes and dependency constraints from PyPI (optional). Run this to confirm the two sha256 hashes exist for 4.53.3 and to inspect requires_dist matches your pinned deps: 🏁 Script executed: #!/bin/bash
set -euo pipefail
VER=4.53.3
# 1) Show all available SHA256 digests for the release
echo "===> Available SHA256 digests for transformers ${VER}"
curl -sS https://pypi.org/pypi/transformers/${VER}/json | jq -r '.releases["'${VER}'"][] | "\(.filename) \(.digests.sha256)"'
# 2) Check that the pinned hashes are present
PINNED_HASHES=(
"5aba81c92095806b6baf12df35d756cf23b66c356975fb2a7fa9e536138d7c75"
"b2eda1a261de79b78b97f7888fe2005fc0c3fabf5dad33d52cc02983f9f675d8"
)
echo "===> Verifying pinned hashes"
for h in "${PINNED_HASHES[@]}"; do
if curl -sS https://pypi.org/pypi/transformers/${VER}/json | jq -e --arg H "$h" '.releases["'${VER}'"][] | select(.digests.sha256==$H)' >/dev/null; then
echo "OK: hash $h found"
else
echo "MISSING: hash $h not found"; exit 1
fi
done
# 3) Inspect runtime requirements for compatibility
echo "===> requires_dist for transformers ${VER}"
curl -sS https://pypi.org/pypi/transformers/${VER}/json | jq -r '.info.requires_dist[]' || true Length of output: 334 Action Required: Verify transformers==4.53.3 on PyPI The PyPI metadata query returned
Locations to update:
Current snippet: -transformers==4.53.3; python_full_version >= '3.9.0' \
- --hash=sha256:5aba81c92095806b6baf12df35d756cf23b66c356975fb2a7fa9e536138d7c75 \
- --hash=sha256:b2eda1a261de79b78b97f7888fe2005fc0c3fabf5dad33d52cc02983f9f675d8 Suggested fix:
🤖 Prompt for AI Agents
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check again There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain</script>🏁 Script executed:
Length of output: 269516 @jiridanek Confirmed. transformers 4.53.3 is on PyPI and the pinned hashes match:
Also sanity-checked requires_dist vs our env:
No changes needed; the requirements entry is correct. 🧠 Learnings used
|
||
triton==3.2.0; platform_system == 'Linux' and platform_machine == 'x86_64' \ | ||
--hash=sha256:30ceed0eff2c4a73b14eb63e052992f44bbdf175f3fad21e1ac8097a772de7ee \ | ||
--hash=sha256:8009a1fb093ee8546495e96731336a33fb8856a38e45bb4ab6affd6dbc3ba220 \ | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Transformers bump to ~=4.53.3 looks good and matches imagestream (major.minor 4.53).
Aligned with project conventions and prior TrustyAI assessments; no obvious compatibility flags with Torch 2.6.0. Ensure lockfile and build reflect this.
Run to verify consistency across Pipfile.lock and imagestream:
🏁 Script executed:
Length of output: 704
Fix Pipfile.lock to Resolve Transformers Bump
The Pipfile correctly pins
transformers = "~=4.53.3"
, and the imagestream manifest shows the expected major.minor4.53
. However, your Pipfile.lock is still resolving Transformers to==4.52.4
. Please update the lockfile so it reflects the bump to4.53.x
.• Pipfile (line 20):
transformers = "~=4.53.3"
• Pipfile.lock (currently):
default.transformers.version == 4.52.4
• Imagestream manifest (manifests/base/jupyter-trustyai-notebook-imagestream.yaml):
{"name": "Transformers", "version": "4.53"},
Action required:
pipenv lock
(or the equivalent command) to re-resolve dependencies.transformers
at>=4.53.3,<4.54.0
.This will ensure your build and deployments use the intended Transformers version.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 1130
@jiridanek Good news! The Pipfile.lock has been properly updated. All versions are now correctly aligned:
• Pipfile (line 20):
transformers = "~=4.53.3"
• Pipfile.lock:
transformers == 4.53.3
✓• Imagestream manifest (N-version):
Transformers 4.53
✓The transformers dependency is now consistently at version 4.53.3 across all configuration files. The issue I previously flagged has been resolved.
🧠 Learnings used
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!